Skip to content

Conversation

@valarnin
Copy link
Collaborator

@valarnin valarnin commented Jan 1, 2026

Fixes #626.

As mentioned in the linked issue, there are some properties I've been wanting to add to data for a while now. This PR adds those new properties.

This is completely untested currently, and I likely won't get around to testing it more or touching it until after week 1 savage prog is done, at the least.

Things that need to be tested:

  • Does this even load at all and work without blowing up
  • Do the new meId, zoneName, zoneId properties get valid data
  • Do the new timeline functions work at all, and do they not break the timeline
  • Do the modified triggers work
  • The above three questions, except for raidemulator

@github-actions github-actions bot added raidboss /ui/raidboss module config ui/config, ui/[module]/config test /test, /ui/test raidemulator /ui/raidemulator module labels Jan 1, 2026
@jacob-keller
Copy link

I'm going to merge this in my personal branch and help test it.

@jacob-keller
Copy link

I can confirm this doesn't crash and the regular triggers work fine. I haven't yet confirmed if modified triggers behave as expected though.

@jacob-keller
Copy link

This is working for me, at least with respect to the zoneId.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config ui/config, ui/[module]/config raidboss /ui/raidboss module raidemulator /ui/raidemulator module test /test, /ui/test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

override General Shirk/Provoke triggers for Cloud of Darkness Chaotic

2 participants