raidboss: Add window to Divine Judgment TEA timeline

[valarnin]

Because the Divine Judgement non-enrage cast is based on when you push the boss to 1%, the timing of the ability can vary significantly. This causes the following Down for the Count and --targetable-- timeline entries to be very incorrect even when killing at the last possible second.

Before:

 -0.098 |  169 | 705.7 "J Storm + Waves x16" Ability { id: "4876", source: "Brute Justice" } duration 50
 Missed |  170 | 731.7 "Eternal Darkness Enrage" Ability { id: "4875", source: "Cruise Chaser" }
 Missed |  171 | 771.9 "Divine Judgment Enrage" Ability { id: "4879", source: "Alexander Prime" } window 67,5
 Missed |  172 | 787.3 "Divine Judgment" Ability { id: "487A", source: "Alexander" }
+41.681 |  177 | 900.0 "--sync--" Ability { id: "4A8B", source: "Perfect Alexander" } window 900,0
 -0.013 |  178 | 909.1 "The Final Word" Ability { id: "487D", source: "Perfect Alexander" }

After:

 -0.098 |  169 | 705.7 "J Storm + Waves x16" Ability { id: "4876", source: "Brute Justice" } duration 50
 Missed |  170 | 731.7 "Eternal Darkness Enrage" Ability { id: "4875", source: "Cruise Chaser" }
 Missed |  171 | 771.9 "Divine Judgment Enrage" Ability { id: "4879", source: "Alexander Prime" } window 67,5
 -8.118 |  172 | 787.3 "Divine Judgment" Ability { id: "487A", source: "Alexander" } window 80,10
+49.799 |  177 | 900.0 "--sync--" Ability { id: "4A8B", source: "Perfect Alexander" } window 900,0
 -0.013 |  178 | 909.1 "The Final Word" Ability { id: "487D", source: "Perfect Alexander" }

This change covers the entire window of possibility for kill timing:

• My group holds DPS at the end until there's less than 1 second left on the castbar for the enrage, to align cooldowns in PA, which puts our KT ~8s after the original timeline source. Hence, 10s window after the timeline entry
• The earliest possible KT is after BJCC land and are killed, hence the 80s window before the timeline entry

[cactbotbot]

@valarnin Thanks for your contribution! 🌵🚀

[wexxlee]

If waiting until the last possible second to kill AP can push Divine Judgment back to something more like 795.3, would it make sense just to change the timeline entry to 795.3 and then do a window 90,2?

Since the ability timing is variable, the exact time listed on the line is I guess a bit arbitrary, but it will control when the ability shows up on the timeline by default until there's a sync. In that case, I think it might make more sense for the default position to be at the latest possible execution time, and then let it sync if it happens early. Otherwise, you would end up with the ability running on the timeline and disappearing while the phase is still active (even though it will later sync), which seems less optimal.

[valarnin]

I don't have exact timings for everything and my team's done with TEA for now, so I could only submit this adjustment because it's the only one I was actually able to test.

If we bump the start time up for Divine Judgement, then the following Down for the Count and --targetable-- entries also need to be bumped up, and I'm not sure if the linear time increase of +8s would always be applicable or not. We always kill extremely close to the cast finishing, so if e.g. a speedkill run were attempted, I'm not sure if those times would still line up.

I can adjust the times for those as part of this PR as requested, but I don't have any way to actually test those changes beyond the one log file I still have ready for testing.

[wexxlee]

If we bump the start time up for Divine Judgement, then the following Down for the Count and --targetable-- entries also need to be bumped up, and I'm not sure if the linear time increase of +8s would always be applicable or not. We always kill extremely close to the cast finishing, so if e.g. a speedkill run were attempted, I'm not sure if those times would still line up.

I can adjust the times for those as part of this PR as requested, but I don't have any way to actually test those changes beyond the one log file I still have ready for testing.

You could test against log files from fflogs. Perhaps grab a handful of recent-ish speedkills?

[JLGarber]

I tend to agree with wexxlee that we want the display time for an ability like this to be the absolute latest that's possible. I don't know of any other situation where the timing of mechanics that follow a synced cast like that would vary, so I think the adjustment should be safe enough, particularly if we can get some confirmation from testing against FFLogs. I'll look at seeing whether I can run some of those tests independently tomorrow and double-check my intuition.

[jacob-keller]

Would it still make sense to have the window merged regardless of adjusting the time value? Since otherwise the timeline doesn't sync up at all, and makes the --targetable-- indicator useless.