Skip to content

ci: bump node to v24 #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiashtra merged 1 commit into from
Jan 5, 2026
Merged

ci: bump node to v24 #928

xiashtra merged 1 commit into from
Jan 5, 2026

Conversation

@xiashtra
Copy link
Collaborator

@xiashtra xiashtra commented Jan 5, 2026

  • bump setup-node to v6
  • bump node to v24

Hopefully resolves issues with the create_npm_package job.

@xiashtra
ci: bump node to v24
11c7f59 
- bump setup-node to v6
- bump node to v24
Hopefully resolves issues with create_npm_package job.
@github-actions github-actions bot added ci /.github/ needs-review Awaiting review labels Jan 5, 2026
@valarnin
Copy link
Collaborator

valarnin commented Jan 5, 2026

Should probably test that all of our actions work properly with node v24 before merging this? I can't imagine there's any sort of breakage but just in case...

@xiashtra
Copy link
Collaborator Author

xiashtra commented Jan 5, 2026

Should probably test that all of our actions work properly with node v24 before merging this? I can't imagine there's any sort of breakage but just in case...

I've had v24 installed locally as the latest LTS for a while without issues, for what it's worth.

valarnin
valarnin approved these changes Jan 5, 2026
View reviewed changes
Copy link
Collaborator

@valarnin valarnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR itself fired most of the actions and they seem fine, so I think this is fine to merge.

@github-actions github-actions bot removed the needs-review Awaiting review label Jan 5, 2026
@xiashtra xiashtra merged commit 2c7548d into OverlayPlugin:main Jan 5, 2026
14 checks passed
@xiashtra xiashtra deleted the bump-node-24 branch January 5, 2026 08:16
github-actions bot pushed a commit that referenced this pull request Jan 5, 2026
gh-pages build: ci: bump node to v24 (#928)
55bb5c1 
- bump setup-node to v6
- bump node to v24

Hopefully resolves issues with the create_npm_package job. 2c7548d
github-actions bot pushed a commit to ShadyWhite/cactbot that referenced this pull request Jan 5, 2026
triggers build: ci: bump node to v24 (OverlayPlugin#928)
674c971 
- bump setup-node to v6
- bump node to v24

Hopefully resolves issues with the create_npm_package job. 2c7548d
github-actions bot pushed a commit to ShadyWhite/cactbot that referenced this pull request Jan 5, 2026
gh-pages build: ci: bump node to v24 (OverlayPlugin#928)
0af0826 
- bump setup-node to v6
- bump node to v24

Hopefully resolves issues with the create_npm_package job. 2c7548d
@Bing-su
Copy link
Collaborator

Bing-su commented Jan 6, 2026

Running the npm install command on node 24 updates the package-lock.json file. It would be good to include these changes in the next related PR.

@xiashtra
Copy link
Collaborator Author

xiashtra commented Jan 6, 2026

Running the npm install command on node 24 updates the package-lock.json file. It would be good to include these changes in the next related PR.

I don't have any changes from running that locally with node v24. Regardless, we are overdue to go through and update our dependencies. @valarnin started working on some of them in #512, but there were some issues with webpack that needed to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@valarnin valarnin valarnin approved these changes

Assignees

No one assigned

Labels

ci /.github/

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xiashtra @valarnin @Bing-su