-
Notifications
You must be signed in to change notification settings - Fork 75
docs: update README and other docs #942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/zh-CN/README.md
Outdated
| [此页面](https://overlayplugin.github.io/cactbot/util/coverage/coverage.html) 列出了当前 Cactbot 中支持的副本。我们会持续添加更多支持 (随时欢迎贡献代码!) 尽管许多旧副本仍未支持。 | ||
| [此页面](https://overlayplugin.github.io/cactbot/util/coverage/coverage.html?lang=cn) 列出了当前 Cactbot 中支持的副本。我们会持续添加更多支持 (随时欢迎贡献代码!) 尽管许多旧副本仍未支持。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coverage doesn't appear to auto-detect language currently (which is probably a bug, given that it has the browserLanguagesToLang function but isn't using it).
Should either fix the coverage auto-detect issue (in a separate followup PR) or keep the lang parameter in the link here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think quisquous just didn't notice that coverage.ts also needs the language detection.
3 years ago: browserLanguagesToLang made separated from raidemulator.ts. quisquous#4584
5 years ago: coverage.ts was added. quisquous#2098
I'll make another PR for auto-detecting the browser language.
I think the browserLanguagesToLang need a small refactor, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue will be resolved via #946.
### README.md - add Traditional Chinese support - update .NET Framework download links - remove DirectX 11 requirement - because FFXIV now supports DirectX 11 version only - include/exclude language parameter for better accessibility - include: cactbot coverage link for each languages - exclude: Microsoft automatically redirects users to the localized version of the site ### CactbotCustomization.md - fix links aff3acd 63a74bb
README.md
CactbotCustomization.md