Conversation
… max object threshold
…ger initialization
…r handling in Sweep
…clean up unused includes in BuiltinFunctions.hpp
… ArrayReferenceScanner and DefaultReferenceScanner for improved memory management
…nner and enhancing DefaultReferenceScanner and ArrayReferenceScanner for better OOP
… BuiltinFactory and optimizing VirtualTableRepository's name lookup
…r stack manipulation
Garbage collector 🫣
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c15c5da3cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (first_error.has_value()) { | ||
| return std::unexpected(*first_error); |
There was a problem hiding this comment.
When Clear() encounters any error, it returns early while gc_in_progress_ is still true (it’s only reset after the error check). If a destructor or repository removal fails, subsequent CollectGarbage() calls will silently no-op because the manager believes GC is already in progress, leaving the VM unable to reclaim memory for the rest of the process. Consider resetting gc_in_progress_ before returning the error (e.g., via a scope guard) so the manager doesn’t get stuck after a failed clear.
Useful? React with 👍 / 👎.
2 participants
No description provided.