Skip to content

Conversation

@MikeBallan
Copy link
Member

No description provided.

@MikeBallan MikeBallan requested a review from catchamonkey March 1, 2017 12:06
@MikeBallan MikeBallan changed the title [Post] Adds new v5 blog post and header asset WIP [Post] Adds new v5 blog post and header asset Mar 1, 2017
<https://github.com/OwlyStuff/amazium#install-amazium>

### General
* Fonts - For v5 we have removed all font files as this kind of thing realy is up to you isn't it, default fonts are still ```san-serif``` but we no longer ships with Maven Pro.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really
sans-serif
ship


### General
* Fonts - For v5 we have removed all font files as this kind of thing realy is up to you isn't it, default fonts are still ```san-serif``` but we no longer ships with Maven Pro.
* Resets - Updates include removing margins as they are now controled by the
Copy link
Member

@catchamonkey catchamonkey Mar 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo controlled

and by the what?

### General
* Fonts - For v5 we have removed all font files as this kind of thing realy is up to you isn't it, default fonts are still ```san-serif``` but we no longer ships with Maven Pro.
* Resets - Updates include removing margins as they are now controled by the
* Lobotomised Owl - For v5 we have changed how margins are added to elements by adding a simple ```&*``` selctor to many of the standard typography elements like p, ol, ul, blockquotes ect.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

etc

* Fonts - For v5 we have removed all font files as this kind of thing realy is up to you isn't it, default fonts are still ```san-serif``` but we no longer ships with Maven Pro.
* Resets - Updates include removing margins as they are now controled by the
* Lobotomised Owl - For v5 we have changed how margins are added to elements by adding a simple ```&*``` selctor to many of the standard typography elements like p, ol, ul, blockquotes ect.
* Typography - We have changed the mesurment used for ```font-size``` & ```line-height``` to use em rather than px. You still set your global font size in px but everywhere else after will use em.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

measurement

@catchamonkey
Copy link
Member

Some typos, intro needs adding, and probably just a check that it's all still correct as there were a few amends before we went stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants