Fix to inprove experience of Southperry to Lith and other fixes from the Java language :)#297
Closed
gerardo-cornejo wants to merge 5 commits intoP0nk:masterfrom
gerardo-cornejo:master
Closed
Fix to inprove experience of Southperry to Lith and other fixes from the Java language :)#297gerardo-cornejo wants to merge 5 commits intoP0nk:masterfrom gerardo-cornejo:master
gerardo-cornejo wants to merge 5 commits intoP0nk:masterfrom
gerardo-cornejo:master
Conversation
The minimun level to go to Ant Tunnel must be 25>
P0nk
reviewed
Apr 30, 2025
| 185000, 190000, 195000, 200000, 205000, 210000, 215000, 220000, 225000, 230000, 235000, 240000, 250000, 260000, 270000, 280000, 290000, 300000, 310000, 320000, | ||
| 330000, 340000, 350000, 360000, 370000, 380000, 390000, 400000, 410000, 420000, 430000, 440000, 450000, 460000, 470000, 480000, 490000, 500000, 510000, 520000, | ||
| 530000, 550000, 570000, 590000, 610000, 630000, 650000, 670000, 690000, 710000, 730000, 750000, 770000, 790000, 810000, 830000, 850000, 870000, 890000, 910000}; | ||
| private static final int[] mobHpVal = {0, 15, 20, 25, 35, 50, 65, 80, 95, 110, 125, 150, 175, 200, 225, 250, 275, 300, 325, 350, 375, 405, 435, 465, 495, 525, 580, 650, 720, 790, 900, 990, 1100, 1200, 1300, 1400, 1500, 1600, 1700, 1800, 1900, 2000, 2100, 2200, 2300, 2400, 2520, 2640, 2760, 2880, 3000, 3200, 3400, 3600, 3800, 4000, 4300, 4600, 4900, 5200, 5500, 5900, 6300, 6700, 7100, 7500, 8000, 8500, 9000, 9500, 10000, 11000, 12000, 13000, 14000, 15000, 17000, 19000, 21000, 23000, 25000, 27000, 29000, 31000, 33000, 35000, 37000, 39000, 41000, 43000, 45000, 47000, 49000, 51000, 53000, 55000, 57000, 59000, 61000, 63000, 65000, 67000, 69000, 71000, 73000, 75000, 77000, 79000, 81000, 83000, 85000, 89000, 91000, 93000, 95000, 97000, 99000, 101000, 103000, 105000, 107000, 109000, 111000, 113000, 115000, 118000, 120000, 125000, 130000, 135000, 140000, 145000, 150000, 155000, 160000, 165000, 170000, 175000, 180000, 185000, 190000, 195000, 200000, 205000, 210000, 215000, 220000, 225000, 230000, 235000, 240000, 250000, 260000, 270000, 280000, 290000, 300000, 310000, 320000, 330000, 340000, 350000, 360000, 370000, 380000, 390000, 400000, 410000, 420000, 430000, 440000, 450000, 460000, 470000, 480000, 490000, 500000, 510000, 520000, 530000, 550000, 570000, 590000, 610000, 630000, 650000, 670000, 690000, 710000, 730000, 750000, 770000, 790000, 810000, 830000, 850000, 870000, 890000, 910000}; |
Owner
There was a problem hiding this comment.
Revert, it was intentionally split every 20 items. Better to keep lines shorter.
| return switch (mapid) { | ||
| case MapId.HALL_OF_WARRIORS, MapId.HALL_OF_MAGICIANS, MapId.HALL_OF_BOWMEN, MapId.HALL_OF_THIEVES, | ||
| MapId.NAUTILUS_TRAINING_ROOM, MapId.KNIGHTS_CHAMBER, MapId.KNIGHTS_CHAMBER_LARGE, | ||
| MapId.KNIGHTS_CHAMBER_2, MapId.KNIGHTS_CHAMBER_3, MapId.PALACE_OF_THE_MASTER -> // aran |
Comment on lines
-494
to
+459
| || Aran.HIDDEN_FULL_DOUBLE == skill || Aran.HIDDEN_FULL_TRIPLE == skill || Aran.HIDDEN_OVER_DOUBLE == skill || Aran.HIDDEN_OVER_TRIPLE == skill | ||
| || Aran.COMBO_SMASH == skill || Aran.DOUBLE_SWING == skill || Aran.TRIPLE_SWING == skill; | ||
| return Aran.FULL_SWING == skill || Aran.OVER_SWING == skill || Aran.COMBO_TEMPEST == skill || Aran.COMBO_FENRIR == skill || Aran.COMBO_DRAIN == skill || Aran.HIDDEN_FULL_DOUBLE == skill || Aran.HIDDEN_FULL_TRIPLE == skill || Aran.HIDDEN_OVER_DOUBLE == skill || Aran.HIDDEN_OVER_TRIPLE == skill || Aran.COMBO_SMASH == skill || Aran.DOUBLE_SWING == skill || Aran.TRIPLE_SWING == skill; |
Owner
There was a problem hiding this comment.
Why remove line breaks? Long lines are generally messy to deal with
Comment on lines
+55
to
+57
| } else if (cm.getPlayer().getLevel() < 25) { | ||
| cm.sendOk("Hmmm... You are too weak to go to the Ant Tunnel. I suggest you train a bit more before going there."); | ||
| cm.dispose(); |
Owner
There was a problem hiding this comment.
Was this a real thing in GMS or something you came up with?
| InventoryManipulator.addFromDrop(c, item, false); | ||
| } else { | ||
| InventoryManipulator.addById(c, reward.itemid, reward.quantity, "", -1); | ||
| c.getPlayer().message("You have received " + reward.quantity + " " + ii.getName(reward.itemid) + " for opening a " + ii.getName(itemId) + "."); |
Owner
There was a problem hiding this comment.
Was this a thing in GMS or something you made up?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It's a small fix to inprove the experience with you travel from Southperry to Lith Harbor
Checklist before requesting a review
Screenshots