Prevent potential memory buildup by cancelling removeAfter task#300
Closed
v3921358 wants to merge 1 commit intoP0nk:masterfrom
Closed
Prevent potential memory buildup by cancelling removeAfter task#300v3921358 wants to merge 1 commit intoP0nk:masterfrom
v3921358 wants to merge 1 commit intoP0nk:masterfrom
Conversation
Call getMap().dismissRemoveAfter(this) to cancel the scheduled removeAfter task. This prevents task 9400547 from repeatedly scheduling long-running (90000s) operations, which could lead to memory leak-like accumulation over time.
breakcraft
pushed a commit
to breakcraft/Cosmic
that referenced
this pull request
Jun 14, 2025
|
Close this, it was already solved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call
getMap().dismissRemoveAfter(this)to cancel the scheduledremoveAftertask. This prevents task9400547from repeatedly scheduling long-running (90000s) operations, which could lead to memory leak-like accumulation over time.Description
This change introduces a call to
getMap().dismissRemoveAfter(this)to proactively cancel a previously scheduledremoveAftertask. Without this, task9400547may continuously reschedule operations with a long delay (90000 seconds), leading to memory pressure or leaks. This fix ensures proper lifecycle management and prevents such unbounded task accumulation.Checklist before requesting a review