Use Liquibase for automated database migrations#309
Merged
Conversation
Less static variables and generally cleaner code
Some of these duplicate drops should be kept, but are removed for the sake of efficiency. For example, Stumpy (3220000) should drop multiple Tree Branch (4000003) and Leaf (4000005), but the duplicate have been removed. To fix this, one has to go through the removed drops in this commit and manually reintroduce the drops that should have been kept. The "RemoveDuplicateDrops" tool simplifies this a little bit as it produces a file with all the removed drops. As of writing this, it removed duplicate drops from 415 mobs, for a total of 7331 removed drops. The following SQL query finds the amount of duplicate drops in the database: SELECT COUNT(*) total_mobs_with_duplicate_items, SUM(extra_item_drops) AS total_duplicate_items FROM (SELECT dropperid, SUM(extras) AS extra_item_drops FROM (SELECT dropperid, itemid, COUNT(*) - 1 AS extras FROM lb_drop_data GROUP BY dropperid, itemid HAVING COUNT(*) > 1) AS i GROUP BY dropperid ORDER BY dropperid ) AS i2
In case you want to add your own custom stuff or change drops or something else.
Global drops are too common, and the ones we have here are not part of vanilla v83
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use Liquibase - a database migration tool - to run the database scripts required to get the server going. This simplifies the initial setup as well as making it easier to make changes over time. It's a win for everyone.
In addition to the refactoring of the database setup, some functional changes have also been made:
Checklist before requesting a review
Screenshots