Skip to content

OPENQP Landau-Zener interface#225

Open
JanosJiri wants to merge 2 commits intomasterfrom
openqp-lz
Open

OPENQP Landau-Zener interface#225
JanosJiri wants to merge 2 commits intomasterfrom
openqp-lz

Conversation

@JanosJiri
Copy link
Contributor

@JanosJiri JanosJiri commented Mar 9, 2026

Interface to MRSF-TDDFT implemented in OPENQP. Currently only for Landau-Zener SH.

Created by Katarina Vosovicova (and JJ).

Created by Katarina Vosovicova and JJ
@JanosJiri JanosJiri requested a review from danielhollas March 9, 2026 11:44
@danielhollas
Copy link
Contributor

Cool! I'll have a look this week.

Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Please see some minor suggestion below.

The main suggestion I have is to change the approach of generating the openqp input file. Instead of generating it inside the bash script, it would be simpler to have a template input file (e.g. openqp.inp.template) and use sed to only modify the parts that are variable during MD (e.g. path to geometry, path to guess, number of states etc).
The advantage would be that if the user wants to e.g. add some parameter to the input file, they can simply modify just the template file, instead of having to add the variable to the openqp.inp and then print it in the script. Does that make sense?

I think SHARK uses a similar strategy, and it's probably something we should do in other interfaces as well in the future.
Note that specifically for Surface Hopping we couldn't do that for Molpro since Molpro's input file is way more complicated and we do need to generate it on the fly.

@JanosJiri JanosJiri requested a review from danielhollas March 13, 2026 19:34
@JanosJiri
Copy link
Contributor Author

JanosJiri commented Mar 13, 2026

Thanks for all the suggestions, @danielhollas! Katka processed them all and created this new version. However, I don't understand why the tests fail since we uploaded only an interface; we did not touch the code at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants