Supports animated gif with Imagick/Gmagick drivers#2
Supports animated gif with Imagick/Gmagick drivers#2aVadim483 wants to merge 2 commits intoPHPixie:masterfrom
Conversation
|
Thanks a lot! |
|
I think you need just to add .gif picture in the current test. And it must be your brand picture - the fairy, but animated :) |
|
I didn't add new methods, I have refactored code in exiting methods. Of course, animated gifs works only with Imagick/Gmagick, under GD it works as static image with single frame. |
|
In this case being able to handle animate gifs is the added functionality. I imagine the test would try and perform these operations on an animated gif, make sure the changes are applied and that the gif stays animated after its saved. Having these tests will make sure that in the future someone is not going to break your gif support by accident |
|
Would it also work for the GMagick driver ? Since it's almost 100% same as Imagick one ? |
No description provided.