Clearer error when using singular models #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit 1. Use singular.ok=FALSE in lm.fit(log(Y) ~ X) which causes a traceable R error 2. Update documentation. 3. Write tests.
mahendra-mariadassou
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR proposes to solve #156 by improving error message.
I propose to use$M M^\top$
lm.fit(log(Y) ~ X, singular.ok=FALSE)incompute_PLN_starting_point. This causes a traceable R error instead of an error in the C++ optimization routine when trying to invertI also wrote two tests for singular model matrix with continuous and discrete covariates. I only updated the documentation of
compute_PLN_starting_point.