Open
Conversation
…iple requests. I wasn't able to fiture out how to update the `PRaynoCasAuthExtension` to load the session without requiring the `services.yml` to be updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @PRayno, here is a first pass at providing user attributes that might be contained in the CAS response as part of the CasUser object, to resolve #5.
In order to test this, I needed to add some unit tests and supporting files so that
phpunitwould run.Also, in order for the attributes to be maintained so that they can be used on subsequent page-loads when
CasUserProvider->loadUserByUsername()gets called, I needed to inject the Session service into theCasUserProvider. While is easy to do in an application'sservices.yml, I couldn't figure out a way to have that service injected in thePRaynoCasAuthExtension::load()method or other way that would just work without requiring the extra configuration step. As far as I can tell only the username gets automatically persisted in the session -- not the full user object, though maybe there is another way to tell Symfony to persist the full user object.While this PR is currently operational, there could certainly be a better way to accomplish this goal.