-
Notifications
You must be signed in to change notification settings - Fork 45
Elastic Search Implementation for Advanced Search #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-3.6.1
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the β¨ Finishing touchesπ§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| } | ||
|
|
||
| /** | ||
| * NEW Elasticsearch-based advanced search endpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every code added is "new". π€·πΎ
|
|
||
| // Get userId from JWT token | ||
|
|
||
| String jwtToken = httpRequest.getHeader("Jwttoken"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indent looks off.
Why do we keep reusing this logic in every controller?
Shouldn't this be an abstraction/ middleware that can inject current user id?
| iemr.session.expiry.time.changePassword=600 | ||
|
|
||
| identity-api-url-advancesearch =IDENTITY_BASE_URL/id/advanceSearch | ||
| identity-api-url-advancesearch-es =IDENTITY_BASE_URL/beneficiary/advanceSearchES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
advanced, not advance




π Description
JIRA ID:
AMM-1951
β Type of Change