Open
Conversation
Contributor
Deploying packrat-landing with
|
| Latest commit: |
d876879
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://798b1c03.packrat-landing.pages.dev |
| Branch Preview URL: | https://feat-catalog-etl-r2-image-up.packrat-landing.pages.dev |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Isthisanmol
force-pushed
the
feat/catalog-etl-r2-image-upload
branch
from
10864c4 to
7d90373
Compare
Contributor
Deploying packrat-guides with
|
| Latest commit: |
d876879
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://369d0c9a.packrat-guides-6gq.pages.dev |
| Branch Preview URL: | https://feat-catalog-etl-r2-image-up.packrat-guides-6gq.pages.dev |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements image upload functionality for the catalog ETL process, enabling automatic upload of product images to a dedicated R2 bucket during data processing.
Key changes:
- Adds support for a new 'images' bucket type to handle image storage separately from catalog data
- Implements image download, validation, and upload logic within the ETL pipeline
- Replaces original image URLs with R2 storage keys for processed catalog items
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/api/src/services/r2-bucket.ts | Adds 'images' bucket type and maps it to PACKRAT_SCRAPY_BUCKET_R2_BUCKET_NAME environment variable |
| packages/api/src/services/etl/queue.ts | Implements image processing logic including download, validation, upload to R2, and URL replacement in catalog items |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
@mikib0 Would you also take a look? As you are working on etl actively. |
Collaborator
|
Good call @Isthisanmol! cuz there would like be clash with the work here #1625. I'll look into this once I get that in since it's currently a blocker for ETL. That okay? |
Collaborator
Author
Yeah, sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.