fix(ai): handle missing AI binding gracefully#1804
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the API’s AIService to avoid crashing in environments where the Cloudflare Workers AI binding (AutoRAG) is unavailable (e.g., tests), by making RAG initialization optional and returning empty RAG search results when it’s missing.
Changes:
- Make
guidesRAGnullable and only initialize it when the AI binding exposesautorag. - Return an empty RAG search response when
guidesRAGis not available.
| // Only initialize RAG if AI binding is available (Cloudflare Workers environment) | ||
| if (this.env.AI && typeof this.env.AI.autorag === 'function') { | ||
| this.guidesRAG = this.env.AI.autorag(this.env.PACKRAT_GUIDES_RAG_NAME); | ||
| } |
There was a problem hiding this comment.
The PR description/linked issue (#1723) is about template pack item detection for items without images, but this change only guards against missing Cloudflare AI bindings / AutoRAG initialization. Please either update the PR description/issue linkage to match the actual fix, or include the missing code changes that address the image-related detection behavior.
| // Return empty results if AI binding is not available (e.g., in test environment) | ||
| if (!this.guidesRAG) { | ||
| return { | ||
| object: 'vector_store.search_results.page' as const, | ||
| search_query: query, | ||
| has_more: false, | ||
| next_page: null, | ||
| data: [], |
There was a problem hiding this comment.
Returning an empty result set when the AI binding is missing can silently mask production misconfiguration (e.g., missing Workers binding or wrong RAG name) and make failures harder to detect. Consider logging a warning (or throwing) when ENVIRONMENT is production, and only returning empty results in explicit test/dev scenarios.
1 participant
Summary
Fixes #1723: AI detects ALL template pack items regardless of image presence.
Changes
Why
The AI binding may not be available in all environments (Cloudflare Workers, tests). This fix ensures the service gracefully handles missing AI without crashing.
Testing