Fix: Owner View in Trips Page#880
Open
MuhammadHassan03 wants to merge 16 commits intoPackRat-AI:andrew_testingfrom
Open
Fix: Owner View in Trips Page#880MuhammadHassan03 wants to merge 16 commits intoPackRat-AI:andrew_testingfrom
MuhammadHassan03 wants to merge 16 commits intoPackRat-AI:andrew_testingfrom
Conversation
Collaborator
There was a problem hiding this comment.
It should be zeego menu for all crud not individual columns fyi see how we handled pack items
Collaborator
Author
There was a problem hiding this comment.
noted that, i'll change it rn..
Collaborator
Author
There was a problem hiding this comment.
I have updated the table items with zeego menu implementation in trips creation page please check it out.
andrew-bierman
requested changes
May 2, 2024
Collaborator
andrew-bierman
left a comment
andrew-bierman
left a comment
There was a problem hiding this comment.
Looks good. Thanks
Just clean this PR up when possible please, what changes are actually needed to fix this issue?
- hardcoded keys
- logs
- migration changes
MuhammadHassan03
force-pushed
the
andrew_testing
branch
2 times, most recently
from
de56149 to
43d58fc
Compare
Collaborator
Author
|
@andrew-bierman I have tried many times to clean this PR but as u have elobrated to me that remove all console.log's, i did same but still it shows conflict in these files but i cannot see any conflict in my local branch...:( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the trips page, click on view owner redirects to the owner profile