Skip to content

Make CopyPackModal component in packs#918

Open
Isthisanmol wants to merge 1 commit intoandrew_testingfrom
copy-pack-implementation
Open

Make CopyPackModal component in packs#918
Isthisanmol wants to merge 1 commit intoandrew_testingfrom
copy-pack-implementation

Conversation

@Isthisanmol
Copy link
Collaborator

Make Copy pack modal component in packs

@Isthisanmol Isthisanmol requested a review from andrew-bierman May 9, 2024 19:41
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2024

❌ Tests failed for this pull request. 😞

View Test Workflow

@cloudflare-workers-and-pages
Copy link
Contributor

Deploying packrat with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9caa087
Status: ✅  Deploy successful!
Preview URL: https://1eaf79d9.packrat.pages.dev
Branch Preview URL: https://copy-pack-implementation.packrat.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2024

iOS app build failed!
Please check the workflow logs for more details on the build failure.

@JewelTee
Copy link
Collaborator

JewelTee commented May 12, 2024

@Isthisanmol hi! Thanks for this update. The Copy Pack feature is working fine, but the page loads a bit slowly after copying a pack, and the text alignments are broken. The edit and delete options are not working as well. Please check the screen recording and screenshot below for reference. Thank You!

Screen.Recording.2024-05-12.at.20.23.37.2.mov
Screenshot 2024-05-12 at 20 41 19

@EngrAJ8888
Copy link
Collaborator

Hi @Isthisanmol, I've noticed that the copy option is currently available only when users open their own packs. However, it should be visible when users open packs created by others. The idea is that when users browse packs from other users in the global, they should have the option to copy all items from those packs. I hope that helps. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants