-
Notifications
You must be signed in to change notification settings - Fork 690
[UT] Add GLM E2E tests for non-MTP and MTP #6163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Thanks for your contribution! |
gongshaotian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
EmmonsCurse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GLM_45 的两个测试 case 建议调整基准值及执行结果的存储路径名称。当前 glm45air 与之前的单卡用例存在路径冲突,建议在多卡场景下增加 _tp4 后缀进行区分,例如:glm45air_tp4 与 glm45air_mtp_tp4
之前的单卡是 fake 模型,相关单测已经移除了 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6163 +/- ##
==========================================
Coverage ? 67.40%
==========================================
Files ? 381
Lines ? 49936
Branches ? 7820
==========================================
Hits ? 33661
Misses ? 13814
Partials ? 2461
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Motivation
N/A
Modifications
N/A
Usage or Command
N/A
Accuracy Tests
N/A
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.