[Tools] Migrate NO_NEED_CONVERT to api_mapping.json and rename matcher class
#807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
The NO_NEED_CONVERT_LIST in global_var.py contained numerous duplicate and unnecessary entries, which made the list difficult to maintain and review. This commit cleans up the list by removing all redundant items, leaving only the essential entries that are genuinely required. The cleanup improves code clarity and reduces potential confusion when managing the conversion exclusions.
- Rename NoNeedConvertMatcher class to ChangePrefixMatcher in api_matcher.py - Update API mapping in CONTRIBUTING.md to reflect matcher name change - Update references in global_var.py and basic_transformer.py
… and adjust tests
LittleHeroZZZX
changed the title
NO_NEED_CONVERT to api_mapping.json and rename matcher class
zhwesky2010
reviewed
Jan 20, 2026
Collaborator
There was a problem hiding this comment.
- torch.fft.fftfreq这个能用ChangePrefixMatcher吗
- GlobalManager.NO_NEED_CONVERT_LIST这个名单不再需要了，后面直接改api_mappin.json就行。GlobalManager.NO_NEED_CONVERT_LIST这些其他位置代码也都移除了，这个概念以后就不需要了
- 目前优先级NO_NEED_CONVERT_LIST>ALIAS_MAPPING>API_MAPPING，移除NO_NEED_CONVERT_LIST后会导致ALIAS优先生效，因此需要清理ALIAS_MAPPING，API_MAPPING中的key不应该在ALIAS_MAPPING中出现。
- 为了确保ChangePrefixMatcher真正实现了『API完全一致』效果，单测基类APIBase里还得增强下，检查转换完后的代码必须有
self.pytorch_api[1:](类方法为self.pytorch_api[-1])，防止被别名替换了。
Contributor
Author
可以，rfftfreq 和 fftfreq 都可以
Done
下个 commit 再提， BTW 这个链接访问不了 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Docs
本 PR 将 NO_NEED_CONVERT APIs 收入 api_mapping 统一管理，并更名为 ChangePrefixMatcher
PR APIs
具体包括：
Docs 仓工具需要配套修改，关联PR PaddlePaddle/docs#7683
Note：
https://github.com/PaddlePaddle/Paddle/pull/77431/changes 引入 Broken 更新，本 PR 固定 Paddle 为 0119 以测试 CI