Position in the search now correctly updates in the prompt.#14
Open
yb66 wants to merge 1 commit intoPapierkorb:masterfrom
Open
Position in the search now correctly updates in the prompt.#14yb66 wants to merge 1 commit intoPapierkorb:masterfrom
yb66 wants to merge 1 commit intoPapierkorb:masterfrom
Conversation
I noticed that cycling through returned matches wasn't updating `@position`, so I've moved the prompt update (`search_prompt`) into `move_entry` because it wasn't being called consistently, while `update_results` also calls `move_entry`. fix: Prompt position in search wasn't updating, fixed.
Contributor
Author
|
Btw, I haven't really looked at the specs properly but I'll have a think about how to test this. And sorry for peppering you with notifications! Regards, |
Collaborator
|
Oh don't worry, I'm happy you're interested and improving things 😉 Just as an FYI, please allow me a couple days to respond to all the pull requests though, I don't check Github every day! Between work and life I usually don't have as much time as I'd like. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that cycling through returned matches wasn't updating
@position, so I've moved the prompt update (search_prompt)into
move_entrybecause it wasn't being called consistently, whileupdate_resultsalso callsmove_entry.fix: Prompt position in search wasn't updating, fixed.