Skip to content

Move Settings page to src/UI/ #2877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acicovic merged 1 commit into from
Oct 21, 2024
Merged

Move Settings page to src/UI/ #2877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
"files": [
"build/",
"src/",
"views/",
"uninstall.php",
"wp-parsely.php"
],
Expand Down
1 change: 0 additions & 1 deletion phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ parameters:
paths:
- bin/
- src/
- views/
- tests/
- wp-parsely.php
- uninstall.php
Expand Down
1 change: 0 additions & 1 deletion rector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
array(
__DIR__ . '/src',
__DIR__ . '/tests',
__DIR__ . '/views',
__DIR__ . '/uninstall.php',
__DIR__ . '/wp-parsely.php',
)
Expand Down
2 changes: 1 addition & 1 deletion src/UI/class-settings-page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ public function display_settings(): void {
wp_die( esc_html__( 'You do not have sufficient permissions to access this page.', 'wp-parsely' ) );
}

include_once plugin_dir_path( PARSELY_FILE ) . 'views/parsely-settings.php';
include_once plugin_dir_path( PARSELY_FILE ) . 'src/UI/settings-page.php';
}

/**
Expand Down
0 views/parsely-settings.php → src/UI/settings-page.php
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion tests/Integration/UI/SettingsPageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ function () use ( $badge_options ) {
$GLOBALS['parsely_settings_page'] = $settings_page;

$settings_page->initialize_settings();
include plugin_dir_path( PARSELY_FILE ) . 'views/parsely-settings.php';
include plugin_dir_path( PARSELY_FILE ) . 'src/UI/settings-page.php';
self::expectOutputContains( $expected_html );
}

Expand Down