Move plugin Settings page under Parse.ly menu

[acicovic]

Description

With this PR, we're moving the plugin's Settings page under the Parse.ly menu, removing the Parse.ly page from the Settings menu.

The settings page is still accessible using its URL and slug. In other words, trying to access /wp-admin/options-general.php?page=parsely will still work. Although we could try to block this, I don't think we need to. @vaurdan, let me know if you have a different opinion.

The remaining issue to tackle is that success/error messages don't show in the page under its new home.

Motivation and context

Keep all things Parse.ly in a single place.

How has this been tested?

Manual testing, existing tests pass.

Screenshots

Parse.ly Menu	General Menu

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vaurdan]

The remaining issue to tackle is that success/error messages don't show in the page under its new home.

I have been looking into this, and it seems that on pages under Settings the settings notices are always displayed. Since we're moving it outside Settings it must be manually rendered with <?php settings_errors(); ?>.

While I was investigating this, I came across a different solution than yours: instead of removing the menu from the original position, I am registering it under the new Parse.ly menu item instead. I pushed this to a branch so you can take a look if you prefer that approach. Here's the commit: 866be8a

As for the notices not showing up, you can see the fix in the settings-page.php file here.

[acicovic]

I think we can close this PR and go with your solution, it's probably cleaner as it doesn't need the removal. What do you think?

[vaurdan]

Closing in favor of #3186