Merged
Conversation
Contributor
📝 Walkthrough## Walkthrough
This set of changes updates several GitHub Actions workflow files and the `.nvmrc` file. The Node.js version in `.nvmrc` is updated, and the e2e workflow is modified to dynamically use the Node.js version specified in `.nvmrc` instead of a hardcoded value. The integration and unit test workflows are adjusted to change the PHP versions tested, move code coverage runs to different PHP versions, and introduce PHP 8.4 as an experimental target. Comments regarding PCOV compatibility are removed where relevant.
## Changes
| File(s) | Change Summary |
|--------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------|
| .github/workflows/e2e-tests.yml | Modified workflow to dynamically read Node.js version from `.nvmrc` and use it in the setup-node action. |
| .nvmrc | Updated Node.js version from 22.12 to 22.14. |
| .github/workflows/integration-tests.yml | Adjusted PHP matrix: removed 8.3 from main, moved coverage run to 8.3, removed PCOV compatibility warning. |
| .github/workflows/unit-tests.yml | Adjusted PHP matrix: removed 8.3 from main, added 8.2, moved coverage to 8.3, added 8.4 as experimental, removed warning.|
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant Workflow
participant NVMRC
participant SetupNode
Workflow->>NVMRC: Read Node.js version
NVMRC-->>Workflow: Return version (e.g., 22.14)
Workflow->>SetupNode: Setup Node.js using returned version
SetupNode-->>Workflow: Node.js environment readyPossibly related PRs
Suggested reviewers
|
alecgeatches
approved these changes
Apr 15, 2025
github-actions bot
added a commit
that referenced
this pull request
Apr 15, 2025
… Update testing workflows" (080ae9a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With this PR, we're performing some updates to our testing workflows:
Motivation and context
Keep our code updated.
How has this been tested?
All the modified testing workflows should succeed.
Summary by CodeRabbit