Skip to content

Update testing workflows#3276

Merged
alecgeatches merged 4 commits intodevelopfrom
update/testing-workflows
Apr 15, 2025
Merged

Update testing workflows#3276
alecgeatches merged 4 commits intodevelopfrom
update/testing-workflows

Conversation

@acicovic
Copy link
Collaborator

@acicovic acicovic commented Apr 15, 2025

Description

With this PR, we're performing some updates to our testing workflows:

  • We're updating our node version from v22.12 to v22.14, and making our end-to-end tests use that instead of v18 which is EOL this month.
  • We're removing a note about PCOV being potentially incompatible with PHP 8.4, since support for this version of PHP has been introduced in PCOV 1.0.12.
  • We're now using PHP 8.3 for our coverage report.

Motivation and context

Keep our code updated.

How has this been tested?

All the modified testing workflows should succeed.

Summary by CodeRabbit

  • Chores
    • Updated Node.js version in the project environment to 22.14.
    • Improved workflow configuration to dynamically use the Node.js version specified in the project settings.
    • Adjusted PHP versions tested in integration and unit test workflows, including changes to coverage settings and the addition of PHP 8.4 as an experimental target.

@acicovic acicovic added the Maintenance & Fixes Ticket/PR related to codebase maintenance tasks label Apr 15, 2025
@acicovic acicovic added this to the 3.18.0 milestone Apr 15, 2025
@acicovic acicovic self-assigned this Apr 15, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 15, 2025

📝 Walkthrough
## Walkthrough

This set of changes updates several GitHub Actions workflow files and the `.nvmrc` file. The Node.js version in `.nvmrc` is updated, and the e2e workflow is modified to dynamically use the Node.js version specified in `.nvmrc` instead of a hardcoded value. The integration and unit test workflows are adjusted to change the PHP versions tested, move code coverage runs to different PHP versions, and introduce PHP 8.4 as an experimental target. Comments regarding PCOV compatibility are removed where relevant.

## Changes

| File(s)                                                      | Change Summary                                                                                                           |
|--------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------|
| .github/workflows/e2e-tests.yml                              | Modified workflow to dynamically read Node.js version from `.nvmrc` and use it in the setup-node action.                |
| .nvmrc                                                       | Updated Node.js version from 22.12 to 22.14.                                                                            |
| .github/workflows/integration-tests.yml                      | Adjusted PHP matrix: removed 8.3 from main, moved coverage run to 8.3, removed PCOV compatibility warning.              |
| .github/workflows/unit-tests.yml                             | Adjusted PHP matrix: removed 8.3 from main, added 8.2, moved coverage to 8.3, added 8.4 as experimental, removed warning.|

## Sequence Diagram(s)

```mermaid
sequenceDiagram
    participant Workflow
    participant NVMRC
    participant SetupNode

    Workflow->>NVMRC: Read Node.js version
    NVMRC-->>Workflow: Return version (e.g., 22.14)
    Workflow->>SetupNode: Setup Node.js using returned version
    SetupNode-->>Workflow: Node.js environment ready

Possibly related PRs

Suggested reviewers

  • acicovic

</details>

<!-- walkthrough_end -->

<!-- announcements_start -->

> [!TIP]
> <details>
> <summary>⚡💬 Agentic Chat (Pro Plan, General Availability)</summary>
> 
> - We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
> 
> </details>

<!-- announcements_end -->

---

<details>
<summary>📜 Recent review details</summary>

**Configuration used: .coderabbit.yaml**
**Review profile: CHILL**
**Plan: Pro**

<details>
<summary>📥 Commits</summary>

Reviewing files that changed from the base of the PR and between bf179012a55a444982fe9ace8851ea40366b0cf7 and f614351a0fada0270d283329bf911a107dac6ed6.

</details>

<details>
<summary>📒 Files selected for processing (2)</summary>

* `.github/workflows/integration-tests.yml` (1 hunks)
* `.github/workflows/unit-tests.yml` (1 hunks)

</details>

<details>
<summary>✅ Files skipped from review due to trivial changes (1)</summary>

* .github/workflows/integration-tests.yml

</details>

<details>
<summary>🚧 Files skipped from review as they are similar to previous changes (1)</summary>

* .github/workflows/unit-tests.yml

</details>

</details>
<!-- internal state start -->


<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKNwSPbABsvkCiQBHbGlcSHFcLzpIACIAVW5aag8aRHEMIkgAd3wKAGsAMy98TMQAGmj7bAFmdRp6OUhsREp0BngmCXb0ZFtIDEcBFoBmACYAdgA2Up4KfG58ZuRmqSpfbASk5AIw2A9efBExAHItkPh0rJyCopKNGF3GWExSZHOGL2wlRu4iKlpzjK4B4AOUUJA0QmQK0Q8HwWCaUXOkDItDABDAKLCIWQ+VmzEgEgAjAAOaaZBAMWAoZD+NCUgHIjCo/D5MBeeD5EjTbYSEYjDSEgAs00w30SNEguJYOz2/k6+CaBL5Av5kAAgrR/uI4WgfLJuQ9ev5mPgpMg0H18BL/ERnP8LvMaBhxLqUBgmMxuNR4Gp2bh5CzrABhADyADUsuoqVYABJWSDEjTC7rB8MEygwuGQQkaAAMKstmUq3HmFFwPTjCaTd3cWNSDOyeUKxXN/nQXkQ+DFSXo2wR1kriaGkpykFI5CoaQyHWUpD8JFL5ZrDxN4gk3qzgwQTJlzW7KWpYS7uRIC5lCiUAjQe4Y2Ao/mdkaBxcXUWhsIwiGXHl6GCt0h2ah218E1/nyeAohSKdLibG4llgBUvHoBwGAYU96DQfIaD4IFpA8Slnmkb9PB8ecghCRhRUGEdsB3IDYFwXBuEQDgAHpWKIKMqg0D1WKsZxmi8WRWMybgwC9ChBOE7hvC8VjRkmDQjH0YxwCgTFAzQPBCHHZQ6gUVh2C4Xh+GEUQ1wAhomCUKhVHULQdBUkwoDgVBUFFLT0V0ycog9NhnS4KgiwcJwXEgKywVstRNG0XQwEMVTTAMDROKBKoRKuZsSlYkgRhINFsQ0WRmC8DgDGiCqDAsdUAEliDIPSohC5hnADfJHkIxA3AeRtrmKewaG4QDQl4Eh5SaIT7BIUILXAgAPKJQSUCEoQzD9IAAChJABKEccIeZpcHWMA/y+OltSwJ4ZFPLB/G4Lw6SiTIo3QMJsjAVIz32NDEC/SAADF4Ek3ADQ8JbwUhdNJPW1BaFkDA0BqBhdUm2l6ClfFcMgAADDQMAkZgKAYbHJXgSJ0B3VIckRLAsbITpZgwfzQnXCh4BUcnseBEMABEAFEAH0wz5mwAGUapDYFcfuMhQamo6xNOjxzvWhEtgQZB6aBuFmYJZx2YEcntkQbhRA5eQsfBlaoczDBpjIDmGSx3qsqPdBEm4UJtix98syUcDyHoJFcfxwnib8ahdn2jzICeChaGst9dWCJSjCqyw1S8bCN0/N2saUd5nBz5BAxIObX3oUcZMNrp2HUCCuoMUFyCUiromUpKUq4gQMtgltWPOGhfhzgrUi/YrSvKyrqrVOrvJ7SpQrajr0mkbqf0rX3c6gmnz0Hkhh4uutQha3A2bmrJKA8dZxSiBo7oetoLljeMhyfaNBw0EY3XPFqkVP8+kB2SpDuEGHI/gTZwntEQIScsTZm1dDOKgc4mAYHAkQO8OdGgwmfqGCMmRryQBNFIdGeIByvy/m7F+VYhjEVGuNZABCKAYAZH5dg6ABAKlCFYPBBkvTiF9OoeQz1nzUMTIKfgfByCZBaAQmkJBiF0DuCGXCfAAHwAvhJRG00MzTDeB8aBkAADqORaBWAgataGcIygKBWGgOc/pTY2MwPQMups2bM1dIUexNjjTaHhO6J4q9aCp3MBnLOekPxbC7PnUQD1JxRP4O1NxOR9JVyqOyBgjJwgN2UpAZu4IZYrxeOgNs7Iaj6W9g8AA4uoGMVR1RiESS7G4kAACaaoACyAAZBQaD4AYISVmFxkBaBdj/DNCJfBMDyBSWWKI6Sa5ZMTtk+uREp7twMBAMARgu5pR7i0/utF1CjyXBPMqbd061XqhOBezVWpJOKWvAwtZqFb1OJ9IOtMVzUEATItsoEOQQXqPIY0poGRiI0MODGv9/FAKQDNOimoIWf2/ucT6aAQlFJWUg+xHgKC0T6egzBR85FPNIdKSF38RHRl4bihxXZIXDhpamCM9LCm1nobCRUTCWEXDYY+FQXDWV8O9II/079yFVgkaOaRsjCFgpIcRNxlB4CeN8JCiRW9JV/lsbOZWdEfDFEgl2fI2hfB+PRY0QJhEQlpyuZnbOF1onngLvE4ujy5lpL4NXTJqzxDPIKa3SqWzO6hyJhc6eGc54NR8shRwLUwqBgIqvRutYraQ21fAto4Fd5YxDgTImJNwLkzJTfBeMLlSEm/tsKtgplyoBTXOQFub1bJGcKQfSGaaS0XEGwG2618ijixvsQ4oQtaM2ZqEh1UyPVVI8G6ouzrPXl1SQsn1GTa7OjWY3ApGyO4JWcoySu7VPI6VjQvAVnAI7BQTQ8iKNkVDRQcnFQwR6/LqAFvAWgiABZyggjI2gAtUjOFCCpAwR6BD5EJGMAAnLmataAACsSG0CCnQ7B4kIxOSwcesSYkSHCQkDQ7mIYEwJgCFzAwfIYxX0QbUpKCYQohiEbQLmM1iRczjFzLQEYxIhijFg1B2DhJCRoEJLmMYiQGATDoBMOj9GIAGQqV+n9f6xoAboALTE+ggA= -->

<!-- internal state end -->
<!-- tips_start -->

---



<details>
<summary>🪧 Tips</summary>

### Chat

There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=Parsely/wp-parsely&utm_content=3276):

- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  - `I pushed a fix in commit <commit_id>, please review it.`
  - `Generate unit testing code for this file.`
  - `Open a follow-up GitHub issue for this discussion.`
- Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples:
  - `@coderabbitai generate unit testing code for this file.`
  -	`@coderabbitai modularize this function.`
- PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.`
  - `@coderabbitai read src/utils.ts and generate unit testing code.`
  - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.`
  - `@coderabbitai help me debug CodeRabbit configuration file.`

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

### CodeRabbit Commands (Invoked using PR comments)

- `@coderabbitai pause` to pause the reviews on a PR.
- `@coderabbitai resume` to resume the paused reviews.
- `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
- `@coderabbitai full review` to do a full review from scratch and review all the files again.
- `@coderabbitai summary` to regenerate the summary of the PR.
- `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR.
- `@coderabbitai resolve` resolve all the CodeRabbit review comments.
- `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository.
- `@coderabbitai help` to get help.

### Other keywords and placeholders

- Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed.
- Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description.
- Add `@coderabbitai` anywhere in the PR title to generate the title automatically.

### Documentation and Community

- Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit.
- Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback.
- Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

</details>

<!-- tips_end -->

@acicovic acicovic marked this pull request as ready for review April 15, 2025 16:19
@acicovic acicovic requested a review from a team as a code owner April 15, 2025 16:19
@alecgeatches alecgeatches merged commit 080ae9a into develop Apr 15, 2025
40 checks passed
@alecgeatches alecgeatches deleted the update/testing-workflows branch April 15, 2025 19:59
github-actions bot added a commit that referenced this pull request Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance & Fixes Ticket/PR related to codebase maintenance tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants