Skip to content

Revert "build(deps-dev): bump @wordpress/api-fetch from 7.29.0 to 7.32.0"#3733

Merged
acicovic merged 1 commit intodevelopfrom
revert-3728-dependabot/npm_and_yarn/wordpress/api-fetch-7.32.0
Oct 2, 2025
Merged

Revert "build(deps-dev): bump @wordpress/api-fetch from 7.29.0 to 7.32.0"#3733
acicovic merged 1 commit intodevelopfrom
revert-3728-dependabot/npm_and_yarn/wordpress/api-fetch-7.32.0

Conversation

@acicovic
Copy link
Collaborator

@acicovic acicovic commented Oct 2, 2025

Reverts #3728, which creates build issues on the develop branch.

Summary by CodeRabbit

  • New Features
    • No user-facing changes in this release.
  • Refactor
    • Streamlined internal request handling types to reduce complexity without affecting behavior.
  • Chores
    • Updated development dependency versions to improve build consistency and compatibility.

@acicovic acicovic added this to the 3.20.8 milestone Oct 2, 2025
@acicovic acicovic self-assigned this Oct 2, 2025
@acicovic acicovic requested a review from a team as a code owner October 2, 2025 14:03
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 2, 2025

📝 Walkthrough

Walkthrough

Downgrades the @wordpress/api-fetch devDependency in package.json and adjusts TypeScript typing in BaseProvider.fetch by removing the APIFetchOptions generic cast, passing options as APIFetchOptions instead. No other files or logic paths are changed.

Changes

Cohort / File(s) Summary
Dependency version update
package.json
Downgrade devDependency @wordpress/api-fetch from 7.32 to 7.29.
Type signature adjustment in BaseProvider
src/content-helper/common/providers/base-provider.tsx
In fetch, remove APIFetchOptions<true> cast; pass options as APIFetchOptions. No logic or error-handling changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

Deps: JavaScript, Deps

Suggested reviewers

  • vaurdan

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description only contains a single-line revert notice and does not follow the repository’s required template, omitting key sections such as Description, Motivation and context, and How has this been tested. Please update the description to include the standard template headings and provide details for each section, including a clear description of changes, the reason for the revert, and testing steps performed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly indicates that this pull request reverts a specific dependency bump and matches the main change in the changeset, making it immediately understandable to reviewers. It concisely references the original commit and the affected package without extraneous information.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-3728-dependabot/npm_and_yarn/wordpress/api-fetch-7.32.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
package.json (1)

57-57: Use full semantic version for consistency.

The version is specified as 7.29 but should be 7.29.0 to maintain consistency with semantic versioning format (MAJOR.MINOR.PATCH) used by other dependencies in this file.

Apply this diff:

-		"@wordpress/api-fetch": "7.29",
+		"@wordpress/api-fetch": "7.29.0",
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6bf161f and 9ba3e13.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • package.json (1 hunks)
  • src/content-helper/common/providers/base-provider.tsx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{js,ts,tsx,jsx}

⚙️ CodeRabbit configuration file

**/*.{js,ts,tsx,jsx}: "Perform a detailed review of the provided code with following key aspects in mind:

  • Review the code to ensure it is well-structured and adheres to best practices.
  • Verify compliance with WordPress coding standards.
  • Ensure the code is well-documented.
  • Check for security vulnerabilities and confirm the code is secure.
  • Optimize the code for performance, removing any unnecessary elements.
  • Validate JSDoc comments for accuracy, currency, and adherence to WordPress coding standards.
  • Ensure each line comment concludes with a period.
  • Confirm every JSDoc comment includes a @SInCE tag indicating the next version of the plugin to include the code.
  • Guarantee compatibility with the latest version of WordPress, avoiding deprecated functions or features."

Files:

  • src/content-helper/common/providers/base-provider.tsx
🧬 Code graph analysis (1)
src/content-helper/common/providers/base-provider.tsx (1)
src/content-helper/common/providers/base-wordpress-provider.tsx (1)
  • apiFetch (145-189)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: E2E against WordPress latest
🔇 Additional comments (1)
src/content-helper/common/providers/base-provider.tsx (1)

151-151: Confirm apiFetch usage is type-safe. TypeScript compilation with tsc --noEmit succeeds with no errors related to apiFetch or APIFetchOptions, so removing the cast is safe.

@acicovic acicovic merged commit 5936087 into develop Oct 2, 2025
34 checks passed
@acicovic acicovic deleted the revert-3728-dependabot/npm_and_yarn/wordpress/api-fetch-7.32.0 branch October 2, 2025 14:07
github-actions bot added a commit that referenced this pull request Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant