Skip to content

Fix TypeScript build error from @wordpress/api-fetch 7.36.0 upgrade #3876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acicovic merged 2 commits into from
Nov 28, 2025
Merged

Fix TypeScript build error from @wordpress/api-fetch 7.36.0 upgrade #3876

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75a6990
Initial plan
Copilot Nov 28, 2025
e8a1504
Fix APIFetchOptions type parameter for @wordpress/api-fetch 7.36.0 co…
Copilot Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/content-helper/common/providers/base-provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,17 +138,17 @@ export abstract class BaseProvider {
*
* @since 3.15.0
*
* @param {APIFetchOptions} options The options to pass to apiFetch.
* @param {string?} id The (optional) ID of the request.
* @param {APIFetchOptions<true>} options The options to pass to apiFetch.
* @param {string?} id The (optional) ID of the request.
*
* @return {Promise<ContentHelperAPIResponse<any>>} The fetched data.
*/
protected async fetch<T>( options: APIFetchOptions, id?: string ): Promise<T> {
protected async fetch<T>( options: APIFetchOptions<true>, id?: string ): Promise<T> {
const { abortController, abortId } = this.getOrCreateController( id );
options.signal = abortController.signal;

try {
const response = await apiFetch<ContentHelperAPIResponse<T>>( options as APIFetchOptions<true> );
const response = await apiFetch<ContentHelperAPIResponse<T>>( options );

// Validate API side errors.
if ( response.error ) {
Expand Down
Loading