Skip to content

Fix integration tests on PHP 8.2#3932

Merged
acicovic merged 5 commits intodevelopfrom
fix/integration-tests-on-php-8-2
Jan 7, 2026
Merged

Fix integration tests on PHP 8.2#3932
acicovic merged 5 commits intodevelopfrom
fix/integration-tests-on-php-8-2

Conversation

@acicovic
Copy link
Collaborator

@acicovic acicovic commented Jan 7, 2026

Description

This PR attempts to fix integration test failures that occur on PHP 8.2, apparently due to doctrine/instantiator.

Motivation and context

Integration tests failures break our workflow.

How has this been tested?

Running the tests against PHP 8.2.

Summary by CodeRabbit

  • Chores

    • Simplified continuous integration workflow for dependency installation across all PHP versions, eliminating version-specific conditional steps.
    • Added testing utility dependency to improve development environment.
  • Tests

    • Enhanced testing infrastructure consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

@acicovic acicovic added this to the 3.22.0 milestone Jan 7, 2026
@acicovic acicovic self-assigned this Jan 7, 2026
@acicovic acicovic requested a review from a team as a code owner January 7, 2026 10:20
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 7, 2026

📝 Walkthrough

Walkthrough

The pull request simplifies the CI workflow by consolidating PHP version-specific Composer installation steps into a single unconditional step using the ramsey/composer-install action, and adds doctrine/instantiator as a dev dependency to composer.json.

Changes

Cohort / File(s) Summary
CI Workflow Simplification
.github/workflows/integration-tests.yml
Removes PHP version conditional logic (< 8.2 vs >= 8.2) and merges two separate Composer dependency installation steps into a single unconditional step with ramsey/composer-install@v3. Eliminates the ignored-platform-reqs flag previously used for PHP >= 8.2.
Dependency Management
composer.json
Adds doctrine/instantiator ^1.5 || ^2.0 to dev-dependencies; updates formatting with trailing comma for yoast/wp-test-utils entry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested labels

Maintenance

Suggested reviewers

  • vaurdan
  • alecgeatches
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: fixing integration test issues on PHP 8.2, which aligns with the modifications to the workflow file and composer.json dependencies.
Description check ✅ Passed The PR description covers the required sections with sufficient detail: it explains what the fix addresses, why it's needed, and how it was tested, matching the template structure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1fb0afe and f382b48.

📒 Files selected for processing (2)
  • .github/workflows/integration-tests.yml
  • composer.json
💤 Files with no reviewable changes (1)
  • .github/workflows/integration-tests.yml
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: acicovic
Repo: Parsely/wp-parsely PR: 2554
File: src/UI/class-settings-page.php:28-29
Timestamp: 2024-10-12T10:01:08.699Z
Learning: acicovic prefers to use the term "resolve" to indicate that an issue or request has been addressed satisfactorily.
Learnt from: acicovic
Repo: Parsely/wp-parsely PR: 2554
File: src/UI/class-settings-page.php:28-29
Timestamp: 2024-06-18T09:33:19.519Z
Learning: acicovic prefers to use the term "resolve" to indicate that an issue or request has been addressed satisfactorily.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: E2E against WordPress latest
🔇 Additional comments (2)
composer.json (2)

34-34: LGTM! Good practice for git diffs.

The trailing comma addition follows JSON best practices and makes future dependency additions cleaner in version control.


35-35: Both versions are PHP 8.2 compatible with no known security advisories.

The doctrine/instantiator constraint ^1.5 || ^2.0 is appropriate for resolving PHP 8.2 integration test failures. Version 1.5.0 supports PHP 7.1–8.x, and version 2.0.0 supports PHP 8.1+, both covering PHP 8.2. No security advisories exist for these versions.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@acicovic acicovic changed the title Fix/integration tests on php 8 2 Fix integration tests on php 8 2 Jan 7, 2026
@acicovic acicovic changed the title Fix integration tests on php 8 2 Fix integration tests on PHP 8.2 Jan 7, 2026
@acicovic acicovic merged commit 03c9402 into develop Jan 7, 2026
38 checks passed
@acicovic acicovic deleted the fix/integration-tests-on-php-8-2 branch January 7, 2026 10:30
github-actions bot added a commit that referenced this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant