Psl pk pipeline1 by Pavan-Microsoft · Pull Request #1 · Pavan-Microsoft/content-generation-solution-accelerator

Pavan-Microsoft · 2026-02-11T07:45:27Z

Purpose

This pull request introduces several improvements and workflow enhancements, primarily focused on code quality enforcement and CI automation. It adds new GitHub Actions workflows for linting and Markdown link checking, introduces a project-wide Flake8 configuration, and makes a few minor code cleanups and refactorings.

CI/CD and Linting Enhancements:

Added a .github/workflows/pylint.yml workflow to run Flake8 linting on backend Python code during pushes, ensuring code quality and style consistency.
Introduced a .flake8 configuration file to standardize linting rules across the project, specifying line length, ignored rules, and excluded directories.

Documentation Quality Automation:

Added a .github/workflows/broken-links-checker.yml workflow to automatically check for broken links in Markdown files on pull requests and manual workflow triggers, helping maintain documentation quality.

Code Cleanups and Minor Refactors:

Minor code refactors in content-gen/src/backend/app.py to remove unnecessary global statements, as they were not needed for variable access. [1] [2]
Moved the TOKEN_ENDPOINT constant to a more appropriate location in content-gen/src/backend/orchestrator.py and improved exception handling by catching specific exceptions instead of using bare except. [1] [2] [3] [4]
Minor formatting update for endpoint selection logic in image_content_agent.py for improved readability.

- Cleaned up whitespace and formatting in blob_service.py, cosmos_service.py, search_service.py, and settings.py. - Ensured consistent spacing and indentation throughout the codebase. - Enhanced code clarity by removing unnecessary blank lines and aligning comments. - No functional changes were made; this commit focuses solely on code style improvements.

…pipeline1

Copilot

Pull request overview

This PR adds CI automation for Python linting and Markdown link validation, introduces a repo-wide Flake8 config, and applies small backend cleanups (formatting/refactors and more specific exception handling) in the content generation backend.

Changes:

Added GitHub Actions workflows for Python linting and Markdown broken-link checking.
Added a root .flake8 configuration and updated Python backend files for formatting/cleanup.
Minor refactors in backend orchestration logic (constants placement, exception handling) and endpoint selection readability.

Reviewed changes

Copilot reviewed 6 out of 12 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
`content-gen/src/backend/settings.py`	Whitespace/formatting tweaks and minor prompt text formatting cleanup.
`content-gen/src/backend/services/search_service.py`	Formatting changes; search client usage remains synchronous inside async methods.
`content-gen/src/backend/services/cosmos_service.py`	Formatting/whitespace changes only.
`content-gen/src/backend/services/blob_service.py`	Formatting/whitespace changes only.
`content-gen/src/backend/orchestrator.py`	Moves `TOKEN_ENDPOINT`, tightens exception handling, and applies formatting cleanups.
`content-gen/src/backend/models.py`	Formatting/whitespace changes only.
`content-gen/src/backend/app.py`	Removes unnecessary `global` statements and applies formatting cleanups.
`content-gen/src/backend/api/admin.py`	Formatting/whitespace changes only.
`content-gen/src/backend/agents/image_content_agent.py`	Readability/formatting tweaks (no functional changes expected).
`.github/workflows/pylint.yml`	Adds Python lint workflow (currently runs flake8 only).
`.github/workflows/broken-links-checker.yml`	Adds Markdown link checking workflow via Lychee.
`.flake8`	Introduces shared Flake8 configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-11T07:51:16Z

content-gen/src/backend/services/search_service.py

                search_text=query,
                filter=filter_str,
                top=top,
                select=["id", "product_name", "sku", "model", "category", "sub_category",
-                       "marketing_description", "detailed_spec_description", "image_description"]
+                        "marketing_description", "detailed_spec_description", "image_description"]


This is an async method but uses the synchronous Azure SearchClient and synchronous client.search(...), which can block the event loop under load. Consider switching to azure.search.documents.aio.SearchClient (and its async iteration) or running the sync call in a thread executor.

Copilot · 2026-02-11T07:51:16Z

content-gen/src/backend/services/search_service.py

                filter=filter_str,
                top=top,
                select=["id", "name", "filename", "primary_color", "secondary_color",
-                       "color_family", "mood", "style", "description", "use_cases",
-                       "blob_url", "keywords"]
+                        "color_family", "mood", "style", "description", "use_cases",
+                        "blob_url", "keywords"]


Same concern here: synchronous SearchClient.search(...) is called inside an async method, which can block the event loop. Consider using the aio SearchClient or offloading to a thread executor.

Copilot · 2026-02-11T07:51:16Z

.flake8

@@ -0,0 +1,5 @@
+[flake8]
+max-line-length = 88
+extend-ignore = E501


With E501 ignored, max-line-length won’t be enforced by flake8, which can be surprising to readers. Consider either removing max-line-length (if intentionally ignoring line length) or stop ignoring E501 and rely on the configured length.

Suggested change

extend-ignore = E501

Copilot · 2026-02-11T07:51:17Z

.github/workflows/pylint.yml

+          pip install flake8  # Ensure flake8 is installed explicitly
+
+      - name: Run flake8 and pylint
+        run: |
+          flake8 --config=.flake8 content-gen/src/backend  # Specify the directory to lint


The workflow name/filename suggests PyLint, but the job only installs and runs flake8. Either add pylint installation + execution, or rename the workflow/step to reflect flake8 to avoid confusion and false expectations in CI.

Suggested change

pip install flake8 # Ensure flake8 is installed explicitly

- name: Run flake8 and pylint

run: |

flake8 --config=.flake8 content-gen/src/backend # Specify the directory to lint

pip install flake8 # Ensure flake8 is installed explicitly

pip install pylint # Ensure pylint is installed explicitly

- name: Run flake8 and pylint

run: |

flake8 --config=.flake8 content-gen/src/backend # Specify the directory to lint

pylint content-gen/src/backend

Copilot · 2026-02-11T07:51:17Z

.github/workflows/pylint.yml

+    steps:
+      - uses: actions/checkout@v6
+


This workflow uses actions/checkout@v6, while other workflows in this repo pin to v4/v5. If v6 isn’t available (or behaves differently), this will break CI; consider aligning to the same major version used elsewhere in .github/workflows.

Copilot · 2026-02-11T07:51:17Z

.github/workflows/broken-links-checker.yml

+      - name: Checkout Repo
+        uses: actions/checkout@v6
+        with:
+          fetch-depth: 0


This workflow uses actions/checkout@v6, while other workflows in this repo pin to v4/v5. If v6 isn’t available (or behaves differently), this will break CI; consider aligning to the same major version used elsewhere in .github/workflows.

Copilot · 2026-02-11T07:51:17Z

.github/workflows/broken-links-checker.yml

+          args: >
+            --verbose --no-progress --exclude ^https?://
+            ${{ steps.changed-markdown-files.outputs.all_changed_files }}


The lychee args exclude all http/https URLs (--exclude ^https?://), which effectively skips checking external links. If the goal is to catch broken external references, remove/relax this exclude; if the goal is "internal links only", consider documenting that in the workflow name/description.

Copilot · 2026-02-11T07:51:18Z

content-gen/src/backend/services/search_service.py

            self._credential = DefaultAzureCredential()
            return self._credential
        except Exception:
            pass
-        
+


DefaultAzureCredential() construction typically doesn’t validate credentials; it will succeed even when no auth method is configured. Because of that, this try/except will almost never fall back to the API key path—failures will occur later on token acquisition. Consider explicitly attempting a token request here (or prefer API key when configured) so the fallback behavior works as intended.

Copilot · 2026-02-11T07:51:18Z

content-gen/src/backend/orchestrator.py

+                                    except Exception:
                                        pass


'except' clause does nothing but pass and there is no explanatory comment.

Suggested change

except Exception:

pass

except Exception as parse_error:

# If JSON extraction from markdown fails, fall back to original prompt_text

logger.debug("Failed to parse JSON prompt from markdown code block: %s", parse_error)

Copilot · 2026-02-11T07:51:18Z

content-gen/src/backend/orchestrator.py

+                            except Exception:
                                pass


'except' clause does nothing but pass and there is no explanatory comment.

Suggested change

except Exception:

pass

except (json.JSONDecodeError, TypeError, ValueError) as parse_error:

logger.debug("Failed to parse JSON prompt from code block: %s", parse_error)

…emetry template validation, and backend testing

…flow

…emetry template validation, and backend testing

…d improve Docker image handling

…etup documentation

…cripts for quota verification

… parsing failures

…orchestrator.py; add model availability check in quota_check_params.sh

…ve unused fallback logic

…te and pagination for better accuracy

…execution

… and update documentation for login command

…pipeline1

Pavan-Microsoft added 6 commits February 11, 2026 11:25

add flake8 configuration and pylint workflow for code linting

fdd1349

add flake8 configuration and PyLint workflow for code quality checks

0f6e367

add workflow for checking broken links in Markdown files

17aae47

add broken link checker workflow for markdown files

69dc89e

Merge remote-tracking branch 'upstream/psl-pk-pipelines' into psl-pk-…

e269515

…pipeline1

Pavan-Microsoft requested a review from Copilot February 11, 2026 07:45

Copilot started reviewing on behalf of Pavan-Microsoft February 11, 2026 07:45 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

Pavan-Microsoft added 19 commits February 11, 2026 14:24

Add GitHub workflows for CodeQL analysis, stale issue management, tel…

0ff0dc6

…emetry template validation, and backend testing

Fix paths for backend test file checks and coverage reporting in work…

c83c57e

…flow

Add pull request trigger for stale bot workflow on main branch

837b602

Comment out metadata section in azure.yaml

7e4bf97

Uncomment metadata section in azure.yaml

5abe119

Add GitHub workflows for CodeQL analysis, stale issue management, tel…

97c7c6d

…emetry template validation, and backend testing

Fix typo in deployment instructions in README.md

64d9f30

Update deployment workflows to use content-gen directory structure an…

18ca9c0

…d improve Docker image handling

Add Azure account setup and quota check documentation with scripts

a130036

Update README.md to correct paths for quota check and Azure account s…

e98d24b

…etup documentation

Add documentation for Azure account setup and quota checks; include s…

2cf9646

…cripts for quota verification

Enhance error handling in orchestrator.py with debug logging for JSON…

2d8c134

… parsing failures

Enhance compliance JSON parsing error handling with debug logging in …

79ab147

…orchestrator.py; add model availability check in quota_check_params.sh

Refactor quota_check_params.sh to simplify argument handling and remo…

e5d1420

…ve unused fallback logic

Update stale-bot.yml to improve PR branch listing by using closed sta…

6b74c1b

…te and pagination for better accuracy

Update pylint.yml to rename job step for clarity, focusing on flake8 …

73e39f3

…execution

Fix shell script to correctly parse tab-separated subscription output…

b35a3e9

… and update documentation for login command

Merge remote-tracking branch 'upstream/psl-pk-pipelines' into psl-pk-…

a1a5c92

…pipeline1

Add fail flag to broken links checker steps for stricter validation

ddba109

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Psl pk pipeline1#1

Psl pk pipeline1#1
Pavan-Microsoft wants to merge 25 commits intodevfrom
psl-pk-pipeline1

Pavan-Microsoft commented Feb 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 11, 2026

Uh oh!

Copilot AI Feb 11, 2026

Uh oh!

Copilot AI Feb 11, 2026

Uh oh!

Copilot AI Feb 11, 2026

Uh oh!

Copilot AI Feb 11, 2026

Uh oh!

Copilot AI Feb 11, 2026

Uh oh!

Copilot AI Feb 11, 2026

Uh oh!

Copilot AI Feb 11, 2026

Uh oh!

Copilot AI Feb 11, 2026

Uh oh!

Copilot AI Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-                                    except Exception:
-                                        pass
+                                    except Exception as parse_error:
+                                        # If JSON extraction from markdown fails, fall back to original prompt_text
+                                        logger.debug("Failed to parse JSON prompt from markdown code block: %s", parse_error)

-                            except Exception:
-                                pass
+                            except (json.JSONDecodeError, TypeError, ValueError) as parse_error:
+                                logger.debug("Failed to parse JSON prompt from code block: %s", parse_error)

Conversation

Pavan-Microsoft commented Feb 11, 2026

Purpose

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants