Skip to content

🔧 Properly handle openssl version > 1.0.X #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryannowarm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🔧 Properly handle openssl version > 1.0.X #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/news/20190913.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Handled the case when the openssl major version is greater than 1 and the minor version is greater than 0
2 changes: 1 addition & 1 deletion src/mbed_cloud/sdk/sdk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def check_openssl_version():
minor = int(match.group(3))
patch = int(match.group(4))

if major >= 1 and minor >= 0 and patch >= 2:
if (major, minor, patch) >= (1, 0, 2):
Copy link
Contributor

@madchutney madchutney Sep 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of tuple comparison, hadn't though of doing that.

return # all ok

warnings.warn("""
Expand Down