SAM History Dumping

[Coontzy1]

Description

Modified --history parameter for SMB to extract password history hashes for SAM in addition to NTDS.

This has minor modifications to the SAM dumping path. Then, modified the logging of hashes into the database if _history is found in the hash name to show accurate count of hashes.

The --history argument was then removed from being exclusive to --ntds as it is needed for --sam.

relevant PRs: fortra/impacket#2059

Type of change

Insert an "x" inside the brackets for relevant items (do not delete options)

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Deprecation of feature or functionality
• This change requires a documentation update
• This requires a third party update (such as Impacket, Dploot, lsassy, etc)

Setup guide for the review

Change the passwords of one (1) or more local users at with default Windows settings to have stored password history hashes.
Then, proceed to target the system with --sam --history

Screenshots (if appropriate):

Default Behavior (pre-PR)

Updated Behavior (With-PR and --history)

Related NTDS argument still working as expected

Checklist:

Insert an "x" inside the brackets for completed and relevant items (do not delete options)

• I have ran Ruff against my changes (via poetry: poetry run python -m ruff check . --preview, use --fix to automatically fix what it can)
• I have added or updated the tests/e2e_commands.txt file if necessary (new modules or features are required to be added to the e2e tests)
• New and existing e2e tests pass locally with my changes
  New e2e tests pass. Various other ones don't, but they should not be affected by my PR.

• If reliant on changes of third party dependencies, such as Impacket, dploot, lsassy, etc, I have linked the relevant PRs in those projects
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (PR here: https://github.com/Pennyw0rth/NetExec-Wiki)

[NeffIsBack]

Thanks for the PR! I'll look into it soon.