fix(snipped): properly parse and set output file for saved screenshots#1122
Merged
Marshall-Hallenbeck merged 1 commit intomainfrom Feb 23, 2026
Merged
fix(snipped): properly parse and set output file for saved screenshots#1122Marshall-Hallenbeck merged 1 commit intomainfrom
Marshall-Hallenbeck merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After #1121, I looked at our other uses of saving files automatically and how we constructed paths for the output files and found one location that was somewhat vulnerable. The snipped module does not parse served pathnames correctly, so you can write to arbitrary folders via absolute paths, but you can't control what the filename is mostly, so this is more so a bugfix than anything (the module was redundantly adding the path to the saved filename as well, so I fixed that).
I used AI to help create a POC, but the code in this PR itself was written by me.
Type of change
Insert an "x" inside the brackets for relevant items (do not delete options)
Setup guide for the review
Requires files in the
$User/Screenshots/directoryScreenshots (if appropriate):
Before:

After:

Checklist:
Insert an "x" inside the brackets for completed and relevant items (do not delete options)
poetry run ruff check ., use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)