PS-10243 feature: Add data structures for GTID set operations (part 1) #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://perconadev.atlassian.net/browse/PS-10243 Changed the definition of the 'util::bounded_string_storage' - instead of being 'std::array<std::byte, N>', it is now 'boost::container::static_vector<std::byte, N>' which is more appropriate because it holds real size in one of its members eliminating the necessity to do 'strlen()' every time we want to use this data as a string. This affected 'server_version' member in the FORMAT_DESCRIPTION event post header and 'tag' in the the GTID_TAGGED_LOG event body. In addition, changed the underlying container for storing 'binlog' member (file name) in the ROTATE event body: instead of 'std::string', we now use 'boost::container::small_vector<std::byte, 64> which will let us avoid dynamic allocations for file names up to 64 bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PS-10243
Changed the definition of the 'util::bounded_string_storage' - instead of being 'std::array<std::byte, N>', it is now
'boost::container::static_vector<std::byte, N>' which is more appropriate because it holds real size in one of its members eliminating the necessity to do 'strlen()' every time we want to use this data as a string. This affected 'server_version' member in the FORMAT_DESCRIPTION event post header and 'tag' in the the GTID_TAGGED_LOG event body.
In addition, changed the underlying container for storing 'binlog' member (file name) in the ROTATE event body: instead of 'std::string', we now use 'boost::container::small_vector<std::byte, 64> which will let us avoid dynamic allocations for file names up to 64 bytes.