Merge macOS compatibility updates from rgov/starter-pack#26
Open
alexchandel wants to merge 24 commits intoPeridexisErrant:masterfrom
Open
Merge macOS compatibility updates from rgov/starter-pack#26alexchandel wants to merge 24 commits intoPeridexisErrant:masterfrom
alexchandel wants to merge 24 commits intoPeridexisErrant:masterfrom
Conversation
0f93124 to
d49972f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge the key macOS compatibility updates from rgov/starter-pack, while reverting the breaking TaskQueue (f004f65 & e38f403) and Unix/POSIX file mode unzipping (1958aac).
Drive-by bugfixes for newlines and for unzipping were recommitted separately (1c84665 & 62f0058).
For now, in the absence of POSIX file mode unzipping, a package builder can properly reextract PyLNP after running
main.pywith:Of course the final distribution zipping still fails, but that's OK since a macOS distribution will be packaged by some other means anyway (e.g. a dmg).