Merged
Conversation
…hashes in telemetry)
115c6c0 to
858677a
Compare
590a805 to
1d5ab01
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds multiple enhancements including support for secured PXHD cookies, sensitive request tracking, additional token information, and telemetry improvements. It also updates dependencies to newer patch versions and modernizes the captcha template implementation.
- Added configuration for secured PXHD cookies and logger severity settings
- Enhanced telemetry reporting with structured configuration format and request tracking
- Changed custom parameters from String to Object type for increased flexibility
- Updated dependencies (Jackson, Commons, SLF4J, Spring, etc.) to newer patch versions
- Improved first-party proxy error handling and URL validation
Reviewed Changes
Copilot reviewed 29 out of 31 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| web/src/main/java/com/web/Config.java | Added px_logger_severity and px_secured_pxhd_enabled configuration options; changed custom params from strings to integers |
| web/pom.xml | Updated slf4j-api from 1.7.25 to 1.7.36 |
| src/main/resources/com/perimeterx/api/blockhandler/templates/captcha_template.mustache | Updated captcha template with improved indentation and renamed function (isCaptchaNotLoaded → isContentLoaded) |
| src/main/java/com/perimeterx/utils/logger/LoggerFactory.java | Fixed spacing in ConsoleLogger constructor call |
| src/main/java/com/perimeterx/models/risk/CustomParameters.java | Changed all custom parameter fields from String to Object with documentation comment |
| src/main/java/com/perimeterx/models/httpmodels/Additional.java | Added isSensitiveRoute and additionalTokenInfo fields |
| src/main/java/com/perimeterx/models/configuration/PXConfiguration.java | Added securedPxhdEnabled field; refactored getTelemetryConfig with redaction logic |
| src/main/java/com/perimeterx/models/configuration/ModuleMode.java | Removed duplicate toValue method and setValue method; made fields final and static |
| src/main/java/com/perimeterx/models/activities/EnforcerTelemetryActivityDetails.java | Changed enforcerConfigs to structured format with activeConfig/staticConfig/remoteConfig; added requestId |
| src/main/java/com/perimeterx/models/activities/CommonActivityDetails.java | Added isSensitiveRoute and additionalTokenInfo fields |
| src/main/java/com/perimeterx/models/PXContext.java | Added isSensitiveRequest and additionalTokenInfo tracking; refactored determineIsSensitiveRequest |
| src/main/java/com/perimeterx/internals/cookie/PXCookie.java | Added additionalTokenInfo method to interface |
| src/main/java/com/perimeterx/internals/cookie/AbstractPXCookie.java | Implemented additionalTokenInfo method to extract "add" field from cookie |
| src/main/java/com/perimeterx/http/PXHttpClient.java | Added proper error handling and resource cleanup in sendEnforcerTelemetry |
| src/main/java/com/perimeterx/api/verificationhandler/DefaultVerificationHandler.java | Added Secure flag to pxhd cookie when securedPxhdEnabled is true |
| src/main/java/com/perimeterx/api/proxy/RemoteServer.java | Changed return type to void; added URL length validation, error handling, and resource cleanup |
| src/main/java/com/perimeterx/api/proxy/DefaultReverseProxy.java | Enhanced URL validation with detailed logging and port handling |
| src/main/java/com/perimeterx/api/blockhandler/templates/TemplateFactory.java | Added CAPTCHA_FIRST_PARTY_FILE_PATH to block script URL |
| src/main/java/com/perimeterx/api/activities/DefaultActivityHandler.java | Updated to pass context to EnforcerTelemetryActivityDetails constructor |
| src/main/java/com/perimeterx/api/activities/BufferedActivityHandler.java | Updated to pass context to EnforcerTelemetryActivityDetails constructor |
| px_metadata.json | Updated supported features list and excluded tests; reordered alphabetically |
| pom.xml | Updated multiple dependencies to newer patch versions |
| ci_files/spec-tests-values.yaml | Added retry configuration for tests |
| ci_files/enforcer-config.json | Removed px_filter_by_route; added px_secured_pxhd_enabled |
| CHANGELOG.md | Added entry documenting all changes in this release |
| .gitignore | Added .smarttomcat to ignore list |
| .github/workflows/* | Updated GitHub Actions versions and test configurations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/resources/com/perimeterx/api/blockhandler/templates/captcha_template.mustache
Show resolved
Hide resolved
src/main/resources/com/perimeterx/api/blockhandler/templates/captcha_template.mustache
Show resolved
Hide resolved
src/main/java/com/perimeterx/api/blockhandler/templates/TemplateFactory.java
Show resolved
Hide resolved
src/main/java/com/perimeterx/api/verificationhandler/DefaultVerificationHandler.java
Show resolved
Hide resolved
src/main/java/com/perimeterx/models/activities/EnforcerTelemetryActivityDetails.java
Outdated
Show resolved
Hide resolved
DorAshkenaziHuman
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perimeterx.atlassian.net/browse/ENT-19165