Skip to content

feat: prevent script change trigger website build#42

Merged
Perry2004 merged 1 commit intomainfrom
feat/path-based-cicd
Oct 12, 2025
Merged

feat: prevent script change trigger website build#42
Perry2004 merged 1 commit intomainfrom
feat/path-based-cicd

Conversation

@Perry2004
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings October 12, 2025 23:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prevents script changes from triggering website builds by adding path filters to GitHub workflows and removing the deploy.sh script. The change ensures that modifications to scripts and documentation don't unnecessarily trigger CI/CD processes.

Key changes:

  • Added path filters to ignore scripts directory and README.md in GitHub workflows
  • Removed the deploy.sh script entirely from the repository
  • Updated .dockerignore to exclude the entire file

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/push-artifacts.yaml Added paths-ignore filter to skip builds when scripts/** or README.md change
.github/workflows/build-check.yaml Added paths-ignore filter to skip PR checks when scripts/** change
deploy.sh Completely removed the deployment script
.dockerignore Entire file removed

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

branches:
- main
paths-ignore:
- scripts/**
Copy link

Copilot AI Oct 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paths-ignore filter excludes 'scripts/**' but the deploy.sh script being removed was in the root directory, not in a scripts folder. Consider whether this filter correctly matches your intended directory structure.

Suggested change
- scripts/**
- scripts/**
- *.sh

Copilot uses AI. Check for mistakes.
branches: [main]
types: [opened, synchronize]
paths-ignore:
- scripts/**
Copy link

Copilot AI Oct 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the push-artifacts workflow, this excludes 'scripts/**' but the removed deploy.sh was in the root directory. Verify this path pattern matches your actual scripts location.

Suggested change
- scripts/**
- scripts/**
- '*.sh'

Copilot uses AI. Check for mistakes.
@Perry2004 Perry2004 merged commit c648e85 into main Oct 12, 2025
3 checks passed
@Perry2004 Perry2004 deleted the feat/path-based-cicd branch October 12, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants