Skip to content

fix: pass env var correctly#65

Merged
Perry2004 merged 1 commit intomainfrom
fix/pass-env-var-correctly
Nov 1, 2025
Merged

fix: pass env var correctly#65
Perry2004 merged 1 commit intomainfrom
fix/pass-env-var-correctly

Conversation

@Perry2004
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings November 1, 2025 23:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the Dockerfile to consolidate environment variable declarations. The S3_BUCKET_NAME environment variable definition is moved from appearing multiple times later in the file to a single declaration near the top of the runtime stage, immediately after the ARG declaration.

  • Moved ARG AWS_S3_BUCKET_NAME and ENV S3_BUCKET_NAME declarations to the top of the runtime stage
  • Removed duplicate ENV S3_BUCKET_NAME declarations that appeared after npm ci and playwright install commands

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Perry2004 Perry2004 merged commit 53fc5b4 into main Nov 1, 2025
8 checks passed
@Perry2004 Perry2004 deleted the fix/pass-env-var-correctly branch November 1, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants