Skip to content

fix: longer script waiting time#66

Merged
Perry2004 merged 1 commit intomainfrom
fix/longer-script-waiting-time
Nov 1, 2025
Merged

fix: longer script waiting time#66
Perry2004 merged 1 commit intomainfrom
fix/longer-script-waiting-time

Conversation

@Perry2004
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings November 1, 2025 23:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates configuration values in two areas: increases a timeout duration in the Playwright scraping logic and corrects an environment variable reference in the GitHub Actions workflow.

  • Increased Playwright page wait timeout from 5000ms to 7500ms
  • Fixed GitHub Actions workflow environment variable reference from AWS_S3_BUCKET_NAME to AWS_S3_BUCKET

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
scripts/src/main.ts Increased the waitForTimeout value to allow more time for page loading
.github/workflows/build-lambda-image.yaml Corrected the environment variable reference to match the actual variable name

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Perry2004 Perry2004 merged commit b96aab1 into main Nov 1, 2025
8 checks passed
@Perry2004 Perry2004 deleted the fix/longer-script-waiting-time branch November 1, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants