Skip to content

fix: multi round trying #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perry2004 merged 1 commit into from
Nov 2, 2025
Merged

fix: multi round trying #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion scripts/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ async function getImageLinksPlaywright(url: string): Promise<string[]> {

const maxClicks = 5;
let clickCount = 0;
let triedFinding = false;

while (clickCount < maxClicks) {
const loadMoreButton = await findLoadMoreButton(page);
Expand All @@ -143,7 +144,12 @@ async function getImageLinksPlaywright(url: string): Promise<string[]> {
}
} else {
console.log("No Load More button left to click.");
break;
if (!triedFinding) {
await page.waitForTimeout(5000);
triedFinding = true;
Copy link

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The retry logic should continue the loop after waiting, not just set the flag. Currently, after the 5-second wait and setting triedFinding = true, the loop continues but immediately evaluates findLoadMoreButton again without any indication that the button should now be available. Consider adding continue; after line 149 to make the retry intent explicit.

Suggested change
triedFinding = true;
triedFinding = true;
continue;

Copilot uses AI. Check for mistakes.
} else {
break;
}
}
}

Expand Down