forked from OpenTTD/OpenTTD
-
Notifications
You must be signed in to change notification settings - Fork 0
WIP: Implement GRFv9 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
PeterN
wants to merge
20
commits into
master
Choose a base branch
from
grfv9
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b334a3 to
27cf5b0
Compare
GF_END is 'reserved' in some Windows APIs. Instead of working around it, make GroupFlags an enum class.
…3316) Replaces a raw loop that uses array indexes.
…penTTD#13319) This allows range checks and loops to be slightly simplified.
danish: 68 changes by Lerura-DK
korean: 1 change by telk5093 portuguese: 1 change by azulcosta
During these loading stages the Action 8 is skipped, which would cause the default GRF version to be used instead of that required by the NewGRF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
GRFv9
Description
num-infois now a Word.set-idis now a Word.subroutineis now a Word.parameteris now a DWord.nvaris now a Word.nrandis now a Word.n-idis now a Word.ids...are each now a Word.num-cidis now a Word.cargo-typeis now a Word.num-entis now a Word.offsetis now always a Word, instead of varying depending on feature/flags.num-spritesis now a Word. If bit 15 is set, then this is a label instead of the number of sprites.num-setsis now a Word.num-spritesis now a Word.numis now a Word.labelis now a Word. Labels MUST have bit 15 set. This means there is no longer any conflict with labels overlapping numbers.num-defis now a Word.num-charis now a Word.base-charis now a DWord. This allows custom glyphs between 0x10000 and 0x1FFFFD to be defined.num-entis now a Word.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.