Feature: Increase railtype/roadtype limit #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterN
force-pushed
the
increase-railtype-roadtype-limit
branch
2 times, most recently
from
bfd8809 to
b53f106
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
PeterN
force-pushed
the
increase-railtype-roadtype-limit
branch
from
b53f106 to
395f492
Compare
…ar. (OpenTTD#14641) The button was changed from an action to a menu, which should be WWT_IMGBTN instead of WWT_PUSHIMGBTN.
vietnamese: 4 changes by KhoiCanDev
…roperly on initial construction. (OpenTTD#14633) Split AllocateSpecToStation/RoadStop into Allocate and Assign functions, allowing command tests to occur separately.
Use WWT_PUSHIMGBTN for non-menu buttons so they automatically raise, replacing the custom OnTimeout function.
* ShowDropDownList() now issues a beep, so individual toolbar buttons no longer need to do it. * HandleButtonClick() may be called twice for some buttons, as it is called by automatically for PUSH buttons. This caused some beeps to sound louder than others.
* Rect right/bottom are inclusive so -1 must be taken from width/height. * Misnamed variable, `new_right` is actually `new_top`.
_setting_circle_size and (the incorrectly named) SETTING_HEIGHT variables are now static members of BaseSettingEntry. Neither of these are constants, so they no longer use constant naming style.
`HandleScrollbarHittest` returns min and max coordinates, not x and y. Also avoid referring to the min and max coordinates as top and bottom, as these functions are used for both vertical and horizontal scrollbars.
PeterN
force-pushed
the
increase-railtype-roadtype-limit
branch
from
395f492 to
251d806
Compare
Use Rect methods to position components.
…penTTD#14647) Pass rect instead of breaking it up when possible.
Replaces direct use of -1, making it easier to find.
chinese (simplified): 4 changes by WenSimEHRP catalan: 5 changes by J0anJosep
hungarian: 5 changes by vargaviktor
…nTTD#14628) Use std::variant instead of union for vehicle info. RailVehicleInfo is now non-POD so using in a union causes undefined behaviour.
… order. (OpenTTD#14608) When building a custom station, the callback-derived tile layout is ignored during the bridge height test. This caused a discrepancy between building a station under a bridge vs building a bridge over the same station. Test the station tile layout callback during the bridge height test.
PeterN
force-pushed
the
increase-railtype-roadtype-limit
branch
from
251d806 to
82119e9
Compare
…penTTD#14764) Ensure separator is a valid string.
luxembourgish: 54 changes by phreeze83
english (au): 4 changes by krysclarke english (us): 4 changes by 2TallTyler greek: 4 changes by gh658804 hungarian: 4 changes by vargaviktor russian: 4 changes by Ln-Wolf finnish: 4 changes by hpiirai portuguese: 4 changes by jcteotonio portuguese (brazilian): 4 changes by pasantoro
galician: 17 changes by pvillaverde polish: 4 changes by Rito13
korean: 4 changes by telk5093
norwegian (bokmal): 4 changes by eriksorngard
polish: 4 changes by pAter-exe
…remove The logic in ConNetworkAuthorizedKey for the `authorized_key` command was inverted. The check `if (StrEqualsIgnoreCase(type, name)) continue;` caused the action (add/remove) to be incorrectly executed on the first key type encountered that *did not* match the requested type, rather than the intended one. This resulted in keys specified for 'admin' being added to 'rcon', for example. This commit inverts the condition to ensure the action is performed only when the requested type matches the iterated key name.
Replaces the fixed-size array for company sorting with a std::vector and updates sorting to use std::ranges::sort. This removes the need for manual count management.
portuguese: 21 changes by jcteotonio
…mmands. Avoids passing each via an unrelated type.
Removes fixed-size arrays and replaces indexed access with iteration.
This uses the same cost factors as owned road pieces for consistency.
PeterN
force-pushed
the
increase-railtype-roadtype-limit
branch
from
78139cf to
684b1c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Stuff
Description
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.