Use bash for mkdisk.sh to have pushd and popd#2
Open
muelli wants to merge 2 commits intoPhaeilo:mainfrom
Open
Conversation
On my system, pushd and popd are bash internals, so let's make the script use bash.
On my machine, the syslinux path did not exist. With this change, the script runs more happily.
Owner
|
Nice hack! This script is awful for portability, I think long term it should just be put into an alpine container, which would make a bunch of things less awkward to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my system, pushd and popd are bash internals, so let's make the script use bash.