This repository was archived by the owner on Mar 31, 2025. It is now read-only.
fixes Pages without meta block are rendered empty #351#352
Open
Schlaefer wants to merge 4 commits intoPhileCMS:developfrom
Open
fixes Pages without meta block are rendered empty #351#352Schlaefer wants to merge 4 commits intoPhileCMS:developfrom
Schlaefer wants to merge 4 commits intoPhileCMS:developfrom
Conversation
The raw-content has to be split into meta and content. This was done in two places before (Page and Parser) essentially duplicating the same functionality. Now this responsibility is delegated to the Parser, it is the party with the knowledge on how to detect and extract the meta from the content. The evaluation of meta and content is still done twice as before, so there's still room for performance improvement. But at least the implementations are merged into one code place.
Aligns the method with `MetaInterface::extractContent`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #351
The raw-content has to be split into meta and content.
This was done in two places before (Page and Parser) essentially
duplicating the same functionality. Now this responsibility is delegated to the
Parser, it is the party with the knowledge on how to detect and extract the
meta from the content.
The evaluation of meta and content is still done twice as before, so there's
still room for performance improvement. But at least the implementations are
merged into one code place.