Skip to content

FIX: printLog write error handle#18

Merged
Pho3b merged 2 commits intoPho3b:mainfrom
iamAdityafr:fix/log-write-error-handling
Nov 24, 2025
Merged

FIX: printLog write error handle#18
Pho3b merged 2 commits intoPho3b:mainfrom
iamAdityafr:fix/log-write-error-handling

Conversation

@iamAdityafr
Copy link
Contributor

Fixes (#17)

  • Fixed printLog() to write the error when occuring to Stderr instead of ignoring
  • Made changes to places calling printLog() function

@Pho3b
Copy link
Owner

Pho3b commented Nov 23, 2025

Hi @iamAdityafr, thank you very much for you pull request 😊

I am going to take a look at it ASAP !

@Pho3b
Copy link
Owner

Pho3b commented Nov 23, 2025

@iamAdityafr I added a commit to your pull request to better show what I had in mind.

Since we don’t need to do much with the returned error, I simply printed it inside the printLog method so the user can understand that something went wrong. This avoids having to update every encoder, as I don’t intend to handle the error in any other way than printing it.

Keep in mind that these are generally rare issues, usually related to permissions or other system-level conditions.

Let me know what you think, and I’ll move the PR forward.

@iamAdityafr
Copy link
Contributor Author

@Pho3b Thank you for showing me the approach. Keeping the function signature unchanged and just printing the error - I was overthinking it.
The changes looks good to me.

@Pho3b Pho3b merged commit 7ec81e1 into Pho3b:main Nov 24, 2025
1 check passed
@Pho3b
Copy link
Owner

Pho3b commented Nov 24, 2025

@Pho3b Thank you for showing me the approach. Keeping the function signature unchanged and just printing the error - I was overthinking it. The changes looks good to me.

Thanks to you for taking the time to open this pull request 😊

@Pho3b Pho3b mentioned this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants