Conversation
|
Hi @iamAdityafr, thank you very much for you pull request 😊 I am going to take a look at it ASAP ! |
|
@iamAdityafr I added a commit to your pull request to better show what I had in mind. Since we don’t need to do much with the returned error, I simply printed it inside the printLog method so the user can understand that something went wrong. This avoids having to update every encoder, as I don’t intend to handle the error in any other way than printing it. Keep in mind that these are generally rare issues, usually related to permissions or other system-level conditions. Let me know what you think, and I’ll move the PR forward. |
|
@Pho3b Thank you for showing me the approach. Keeping the function signature unchanged and just printing the error - I was overthinking it. |
Thanks to you for taking the time to open this pull request 😊 |
Fixes (#17)