[Ares Fix] 2 Bugfixes about spawn survivors #2020
Conversation
NetsuNegi
added
Interaction
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
|
It's already implemented in https://github.com/Phobos-developers/Phobos/blob/develop/src/Utilities/AresAddressInit.cpp#L30 |
alright, but why disable it |
NetsuNegi
changed the title
|
I simply gave it a try, but it seems to be ineffective for the first bug. 🤔 |
There were issues that couldn't confirm if they were actually the repercussion of this or something else. If you're also sure it's safe, toggle the tweak before releasing a dev build. |
CrimRecya
left a comment
CrimRecya
left a comment
There was a problem hiding this comment.
Looks good overall. I just have two small questions.
|
|
||
| const auto occupied = pEjectee->IsCellOccupied(pCell, FacingType::None, -1, nullptr, true); | ||
|
|
||
| if (occupied != Move::OK && occupied != Move::MovingBlock) |
There was a problem hiding this comment.
I don't quite understand why Move::MovingBlock is allowed. When another unit is entering this position, I think directly generating units on it will cause overlap.
There was a problem hiding this comment.
it it just copy from vanilla and ares's code
| const auto occupation = scat ? pCell->AltOccupationFlags : pCell->OccupationFlags; | ||
|
|
||
| if (occupation & 0x1C) | ||
| pCell->ScatterContent(CoordStruct::Empty, true, true, scat); |
There was a problem hiding this comment.
As an aside: I'm not sure why only the occupation of infantry was assessed here although the same judgment is also made in Ares.
|
the problem of "viehcle cannot spawn survivors" due to "suicide weapon" is unfixed yet. |
6 participants
Uh oh!
There was an error while loading. Please reload this page.