-
Notifications
You must be signed in to change notification settings - Fork 0
PILOT-7930: fixup upload as zip feature #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses an issue with the upload path when uploading a folder as a zip file by updating the logic in the file upload flow. Key changes include:
- A new test in test_file_upload.py verifying the zip upload behavior.
- Updates in file_upload.py to compress the folder and adjust the upload path when the compress_zip flag is set.
- Minor formatting adjustments in the file upload logic.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/app/services/file_manager/file_upload/test_file_upload.py | Added new test for validating folder upload as zip |
| app/services/file_manager/file_upload/file_upload.py | Updated logic for handling zip compression during upload |
Contributor
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
QXgu
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
after updating on upload type in this PR: #235. It introduced another bug where the upload path is not correct when upload a zip. This PR update the logic for upload as zip. But entire logic need to be refactored later on.
JIRA Issues
PILOT-7930
Type of Change
Please delete options that are not relevant.
Testing
Are there any new or updated tests to validate the changes?
Test Directions
update test cases and test against dev
Versions