Draft
Conversation
Owner
|
Hi, Thank you so much for your contribution and so sorry for the late reply. Please let me know if your change is ready to merge and I will merge it right away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I would like to work on making the HarDNet code more readable so that others can understand and adapt it more easily.
I have started working on some simple things to improve the code such as error handling for unsupported architectures or clearing trailing whitespace.
Currently I have these things in mind:
get_linksto be more concise and also generalise to more than 1024 layers (because of thismap_location=torch.device("cpu")for cpu-based models to work)Please let me know if there's any part you might also want me to look at or if there's something you would like to keep.