Fix conversation title #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slashek
requested changes
Jul 15, 2025
Contributor
Slashek
left a comment
Slashek
left a comment
There was a problem hiding this comment.
Do not invoke GraphQL from partials
Slashek
reviewed
Jul 15, 2025
| assign other_participants_ids = participants_ids | subtract_array: current_participants_ids | ||
| assign from_profile = other_participants_ids | first | ||
| if from_profile | ||
| graphql from_profile = 'modules/profile/profiles/search', id: from_profile |
Contributor
There was a problem hiding this comment.
please do not invoke GraphQL from partials - all data should be fetched in the controller (Page)
Slashek
reviewed
Jul 15, 2025
| render 'modules/common-styling/user/avatar', size: 's', name: name, imageSrc: from_profile.avatar.photo.versions.sm | ||
| endif | ||
| print name | raw_escape_string | ||
| else # conversation was just initiated |
Contributor
There was a problem hiding this comment.
to avoid this big if statement with a lot of duplication, can we just fetch and prepare data in Page?
Contributor
Author
|
@Slashek Thanks for your input, should be much better now. |
Slashek
reviewed
Jul 21, 2025
| render 'modules/common-styling/user/avatar', size: 's', name: name, imageSrc: other_participant.avatar.photo.versions.sm | ||
| render 'modules/common-styling/user/avatar', size: 's', name: name, imageSrc: from_profile.avatar.photo.versions.sm | ||
| endif | ||
| print name | raw_escape_string |
Contributor
There was a problem hiding this comment.
can we just use {{ }} to ensure no XSS attacks etc? I'm not sure if raw_escape_string is enough
Contributor
|
thx @lk316 , one last comment |
Contributor
Author
|
@Slashek fixed |
Slashek
reviewed
Aug 6, 2025
lk316
force-pushed
the
fix-conversation-title
branch
from
3aa5d31 to
24439f1
Compare
Slashek
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://platformos.slack.com/archives/C07910NASF3/p1750960683884329?thread_ts=1737579857.091099&cid=C07910NASF3
https://platformos.slack.com/archives/C04QLE0UY2U/p1752003727986169