@gajaguar<Gerardo Antonio Gerónimo Vasconcelos>#62
Open
gajaguar wants to merge 101 commits intoPlatziMaster:masterfrom
Open
@gajaguar<Gerardo Antonio Gerónimo Vasconcelos>#62gajaguar wants to merge 101 commits intoPlatziMaster:masterfrom
gajaguar wants to merge 101 commits intoPlatziMaster:masterfrom
Conversation
- Create `build`. - Change `dev` to work with typescript. - Add `lint:js` to run `eslint`. - Add `lint` as shortcut of `lint:js`. - Change `start` to execute from `lib` directory. - Add `test` as shortcut of `test:e2e`.
Move the builder to `utils` directory and convert into a class.
Fix an error that cause that only the first registered resource endpoints works.
- Category - Product
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my solution for the pre cohort Platzi Master challenge.
I turn the project into typescript, it mean breaking changes on each comit, lol.
I try implement a little bit of SOLID principles. The test just breaks, no time for fix it.
My efforts were left in this project. I hope it be of your liking.