Adding Platzi Master Frontend by Irving Juárez#91
Open
irvingvjuarez wants to merge 15 commits intoPlatziMaster:mainfrom
Open
Adding Platzi Master Frontend by Irving Juárez#91irvingvjuarez wants to merge 15 commits intoPlatziMaster:mainfrom
irvingvjuarez wants to merge 15 commits intoPlatziMaster:mainfrom
Conversation
…rt in the index.html, I didn't know that tag is useful for the css media queries. Left to do is the onclick for the hamburger button
…. Left to do are the pages and the router
…st fine. Left to do is the content of each page
…th the components I already have will be much easier
…e a fetch and get the data. Maybe I will need to use a loader for the Loading process, but we will see...
…t is kinda strange because I already added all the needed stuff for the key prop. I will check it out again anyways
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I deleted some dependencies because of my computer's memory and I explained why I couldn't resolve some challenges (mostly related to the unit testing), but the project itself runs properly