Skip to content

VS AI Update (#8)#9

Merged
Pnwcomputers merged 1 commit intomainfrom
Version2.2
Oct 31, 2025
Merged

VS AI Update (#8)#9
Pnwcomputers merged 1 commit intomainfrom
Version2.2

Conversation

@Pnwcomputers
Copy link
Owner

  • Clean-ToolOutput -> Convert-ToolOutput (+call site)
  • Run-Tool -> Invoke-Tool (+call sites)
  • Generate-Report -> New-Report (+call sites)
  • Replace param with (alias Args)
  • Avoid automatic var in PsPing
  • Fix comparison order
  • Remove unused var
  • Repair GPU submenu strings causing parse error

Summary

Explain what this PR changes and why.

Type of change

  • Bug fix
  • New feature
  • Docs update
  • Refactor
  • Other (describe):

Checklist

  • I ran tests locally and they pass
  • I updated docs/README as needed
  • I linked related issues (e.g., fixes #123)
  • I followed the coding style & conventions

Screenshots / Demos

If applicable.

Breaking changes

Describe any breaking changes and migration steps.

* Update SystemTester.bat

* Update SystemTester.ps1

* Update SystemTester.bat

* Update README.md

* Update README.md

* Update README.md

* Update SystemTester.bat

* Update SystemTester.ps1

* Update README.md

* Create .gitkeep

* Create CODE_OF_CONDUCT.md

* Create CONTRIBUTING.md

* Create PULL_REQUEST_TEMPLATE.md

* Update CONTRIBUTING.md

* Create bug_report.md

* Create config.yml

* Create deployment_issue.md

* Create feature_request.md

* Create implementation-question.md

* Create COMPATABILITY.md

* Create INSTALLATION.md

* Create TROUBLESHOOTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Delete CONTRIBUTING.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Handle both script names in batch launcher (#3)

* Add network speed and update visibility to reports (#4)

* Improve GPU detection and batch reliability (#5)

* Handle tool verification exit statuses (#6)

* Update README.md

* Fix host:port string interpolation in latency test (#7)

* refactor: use approved verbs and fix analyzer issues

- Clean-ToolOutput -> Convert-ToolOutput (+call site)
- Run-Tool -> Invoke-Tool (+call sites)
- Generate-Report -> New-Report (+call sites)
- Replace  param with  (alias Args)
- Avoid  automatic var in PsPing
- Fix  comparison order
- Remove unused  var
- Repair GPU submenu strings causing parse error
@Pnwcomputers Pnwcomputers merged commit 4095a0b into main Oct 31, 2025
3 of 7 checks passed
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

if ($ToolName -in @("psinfo","pslist","handle","autorunsc","testlimit","contig")) {
$Args = "-accepteula $Args"
}
$argArray = if ($Args.Trim()) { $Args.Split(' ') | Where-Object { $_ } } else { @() }

P1 Badge Use ArgumentList inside tool runner

The tool runner now defines the parameter as [string]$ArgumentList (alias -Args), but inside the body it still reads and rewrites $Args. In PowerShell $Args is the automatic array of unbound arguments, so these lines no longer operate on the parameter value. As a result options like -accepteula and any caller-provided arguments are lost and most tools execute without the intended switches. Replace $Args with $ArgumentList when building the command line.


$duration = ((Get-Date) - $start).TotalMilliseconds
$cleanOutput = Clean-ToolOutput -ToolName $ToolName -RawOutput $rawOutput

P0 Badge Update Clean-ToolOutput call after rename

The output sanitizer was renamed to Convert-ToolOutput, but the tool runner still calls Clean-ToolOutput. Because the old function name no longer exists, every tool invocation will fail with “The term ‘Clean-ToolOutput’ is not recognized,” terminating the run after the first Sysinternals command. Update the call to Convert-ToolOutput to match the new function name.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 271 to +274
function Run-Tool {
param(
[string]$ToolName,
[string]$Args = "",
[Alias('Args')]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Rename Run-Tool so Invoke-Tool resolves

Menu handlers now call Invoke-Tool, but the helper remains declared as function Run-Tool. Because no function or alias named Invoke-Tool exists, the first call in Test-SystemInfo will throw “Invoke-Tool is not recognized” and abort the entire script before any tests run. Rename the definition or reintroduce an alias so the call sites resolve.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant