Conversation
* Update SystemTester.bat * Update SystemTester.ps1 * Update SystemTester.bat * Update README.md * Update README.md * Update README.md * Update SystemTester.bat * Update SystemTester.ps1 * Update README.md * Create .gitkeep * Create CODE_OF_CONDUCT.md * Create CONTRIBUTING.md * Create PULL_REQUEST_TEMPLATE.md * Update CONTRIBUTING.md * Create bug_report.md * Create config.yml * Create deployment_issue.md * Create feature_request.md * Create implementation-question.md * Create COMPATABILITY.md * Create INSTALLATION.md * Create TROUBLESHOOTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Delete CONTRIBUTING.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Handle both script names in batch launcher (#3) * Add network speed and update visibility to reports (#4) * Improve GPU detection and batch reliability (#5) * Handle tool verification exit statuses (#6) * Update README.md * Fix host:port string interpolation in latency test (#7) * refactor: use approved verbs and fix analyzer issues - Clean-ToolOutput -> Convert-ToolOutput (+call site) - Run-Tool -> Invoke-Tool (+call sites) - Generate-Report -> New-Report (+call sites) - Replace param with (alias Args) - Avoid automatic var in PsPing - Fix comparison order - Remove unused var - Repair GPU submenu strings causing parse error
There was a problem hiding this comment.
💡 Codex Review
Lines 298 to 302 in ef7cc2e
The tool runner now defines the parameter as [string]$ArgumentList (alias -Args), but inside the body it still reads and rewrites $Args. In PowerShell $Args is the automatic array of unbound arguments, so these lines no longer operate on the parameter value. As a result options like -accepteula and any caller-provided arguments are lost and most tools execute without the intended switches. Replace $Args with $ArgumentList when building the command line.
Lines 304 to 305 in ef7cc2e
The output sanitizer was renamed to Convert-ToolOutput, but the tool runner still calls Clean-ToolOutput. Because the old function name no longer exists, every tool invocation will fail with “The term ‘Clean-ToolOutput’ is not recognized,” terminating the run after the first Sysinternals command. Update the call to Convert-ToolOutput to match the new function name.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| function Run-Tool { | ||
| param( | ||
| [string]$ToolName, | ||
| [string]$Args = "", | ||
| [Alias('Args')] |
There was a problem hiding this comment.
Rename Run-Tool so Invoke-Tool resolves
Menu handlers now call Invoke-Tool, but the helper remains declared as function Run-Tool. Because no function or alias named Invoke-Tool exists, the first call in Test-SystemInfo will throw “Invoke-Tool is not recognized” and abort the entire script before any tests run. Rename the definition or reintroduce an alias so the call sites resolve.
Useful? React with 👍 / 👎.
Update SystemTester.bat
Update SystemTester.ps1
Update SystemTester.bat
Update README.md
Update README.md
Update README.md
Update SystemTester.bat
Update SystemTester.ps1
Update README.md
Create .gitkeep
Create CODE_OF_CONDUCT.md
Create CONTRIBUTING.md
Create PULL_REQUEST_TEMPLATE.md
Update CONTRIBUTING.md
Create bug_report.md
Create config.yml
Create deployment_issue.md
Create feature_request.md
Create implementation-question.md
Create COMPATABILITY.md
Create INSTALLATION.md
Create TROUBLESHOOTING.md
Update CONTRIBUTING.md
Update CONTRIBUTING.md
Delete CONTRIBUTING.md
Update README.md
Update README.md
Update README.md
Update README.md
Update README.md
Handle both script names in batch launcher (Handle both script names in batch launcher #3)
Add network speed and update visibility to reports (Add network speed diagnostics and Windows update details to reports #4)
Improve GPU detection and batch reliability (Improve GPU detection and batch reliability #5)
Handle tool verification exit statuses (Improve tool verification exit handling #6)
Update README.md
Fix host:port string interpolation in latency test (Fix host:port interpolation in network latency test #7)
refactor: use approved verbs and fix analyzer issues
Summary
Explain what this PR changes and why.
Type of change
Checklist
Screenshots / Demos
If applicable.
Breaking changes
Describe any breaking changes and migration steps.